feat(codegen): print `vite` / `webpack` special comments #6021

Dunqing · 2024-09-24T09:03:58Z

graphite-app · 2024-09-24T09:04:04Z

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Dunqing · 2024-09-24T09:04:15Z

feat(codegen): print vite / webpack special comments #6021 👈
refactor(codegen): simplify printing annotation comments #6027
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Dunqing and the rest of your teammates on Graphite

codspeed-hq · 2024-09-24T09:12:21Z

CodSpeed Performance Report

Merging #6021 will not alter performance

_{Comparing 09-24-refactor_codegen_print_inner_comments (cca433f) with main (efabfc8)}

Summary

✅ 29 untouched benchmarks

crates/oxc_codegen/tests/integration/esbuild.rs

Dunqing · 2024-09-26T04:17:21Z

A lot of minifier cases failed, it looks like the compressor caused some cases to assign an incorrect span

EDIT: Fixed in #6065

crates/oxc_codegen/tests/integration/snapshots/pure_comments.snap

unblock #6021 Keep the original expression's `span` to insert comments correctly. Have tested in #6021 and it worked

Boshen

Can we add some integration tests for vite special comments, including tests that don't match these webpack / vite patterns?

You may add them to crates/oxc_codegen/tests/integration/unit.rs or merge them in pure_comments.rs

Dunqing · 2024-09-26T15:14:18Z

Can we add some integration tests for vite special comments, including tests that don't match these webpack / vite patterns?

You may add them to crates/oxc_codegen/tests/integration/unit.rs or merge them in pure_comments.rs

I added tests for vite special comments in crates/oxc_codegen/tests/integration/unit.rs and non-special comments tests which copy from esbuild in esbuild

graphite-app · 2024-09-26T15:17:34Z

Merge activity

Sep 26, 11:17 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Sep 26, 11:19 AM EDT: Boshen added this pull request to the Graphite merge queue.
Sep 26, 11:23 AM EDT: Boshen merged this pull request with the Graphite merge queue.

Related: #1046 (comment) Close: #6024

## [0.30.2] - 2024-09-27 ### Features - 60c52ba ast: Allow passing span to `void_0` method (#6065) (Dunqing) - cca433f codegen: Print `vite` / `webpack` special comments (#6021) (Dunqing) - 8d026e1 regular_expression: Implement `GetSpan` for RegExp AST nodes (#6056) (camchenry) - 7764793 regular_expression: Implement visitor pattern trait for regex AST (#6055) (camchenry) - f866781 semantic: Check for type annotations on left side of `for..in` and `for..of` iterators (#6043) (DonIsaac) - 8b2e9aa semantic: Check for JSDoc types in TS type annotations (#6042) (DonIsaac) - 28da771 transformer: Do not transform `**` with bigint literals (#6023) (Boshen) ### Bug Fixes - a88504c diagnostics: Check for terminal when displaying links (#6018) (Boshen) - 418ae25 isolated-declarations: Report uninferrable types in arrays (#6084) (michaelm) - e0a8959 minifier: Compute `void number` as `undefined` (#6028) (Boshen) - 0658576 paresr: Do not report missing initializer error in ambient context (#6020) (Boshen) - b1af73d semantic: Do not create a `global` symbol for `declare global {}` (#6040) (DonIsaac) - c8682e9 semantic,codegen,transformer: Handle definite `!` operator in variable declarator (#6019) (Boshen) ### Performance - 6b7d3ed isolated-declarations: Should clone transformed AST rather than original AST (#6078) (Dunqing) - 85aff19 transformer: Introduce `Stack` (#6093) (overlookmotel) - ad4ef31 transformer: Introduce `NonEmptyStack` (#6092) (overlookmotel) ### Documentation - 3099709 allocator: Document `oxc_allocator` crate (#6037) (DonIsaac) - d60ceb4 oxc: Add README.md and crate-level docs (#6035) (DonIsaac) - efabfc8 semantic: Improve doc comments on `Reference` methods (#6076) (overlookmotel) ### Refactor - 1fc80d1 ast: Move all ts ast related impl methods to `ast_impl` (#6015) (Dunqing) - fe696f0 codegen: Simplify printing annotation comments (#6027) (Dunqing) - e60ce50 transformer: Add `SparseStack::with_capacity` method (#6094) (overlookmotel) - 1399d2c transformer: Move `SparseStack` definition into folder (#6091) (overlookmotel) - 6bd29dd transformer: Add more debug assertions (#6090) (overlookmotel) - c90b9bf transformer: Rename `SparseStack` methods (#6089) (overlookmotel) - 2b380c8 transformer: Remove unsued `self.ctx` (#6022) (Boshen) ### Testing - 93575cd semantic: Add comprehensive regression test suite (#5976) (DonIsaac) - a4cec75 transformer: Enable tests (#6032) (overlookmotel) --------- Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

github-actions bot added the A-codegen Area - Code Generation label Sep 24, 2024

Dunqing changed the title ~~refactor(codegen) print inner comments~~ refactor(codegen): print inner comments Sep 24, 2024

Dunqing changed the title ~~refactor(codegen): print inner comments~~ feat(codegen): print inner comments Sep 24, 2024

Dunqing marked this pull request as draft September 24, 2024 09:38

Dunqing mentioned this pull request Sep 24, 2024

refactor(codegen): simplify printing annotation comments #6027

Merged

Dunqing force-pushed the 09-24-refactor_codegen_print_inner_comments branch from c64a88d to c54bd53 Compare September 25, 2024 01:58

Dunqing changed the base branch from main to 09-24-refactor_codegen_simplify_printing_annotation_comments September 25, 2024 01:58

Dunqing force-pushed the 09-24-refactor_codegen_simplify_printing_annotation_comments branch from 3474b45 to 138ccc9 Compare September 25, 2024 02:13

Dunqing force-pushed the 09-24-refactor_codegen_print_inner_comments branch from c54bd53 to c7a7586 Compare September 25, 2024 02:13

Dunqing changed the base branch from 09-24-refactor_codegen_simplify_printing_annotation_comments to graphite-base/6021 September 25, 2024 06:27

Dunqing force-pushed the 09-24-refactor_codegen_print_inner_comments branch from c7a7586 to bc55004 Compare September 25, 2024 06:31

Dunqing force-pushed the graphite-base/6021 branch from 138ccc9 to fe696f0 Compare September 25, 2024 06:31

Dunqing changed the base branch from graphite-base/6021 to main September 25, 2024 06:32

Dunqing force-pushed the 09-24-refactor_codegen_print_inner_comments branch from bc55004 to e9cca9b Compare September 25, 2024 06:32

Boshen assigned Dunqing Sep 25, 2024

Dunqing force-pushed the 09-24-refactor_codegen_print_inner_comments branch from e9cca9b to 2ee73ba Compare September 26, 2024 02:03

Dunqing changed the title ~~feat(codegen): print inner comments~~ feat(codegen): print vite / webpack special comments Sep 26, 2024

Dunqing commented Sep 26, 2024

View reviewed changes

crates/oxc_codegen/tests/integration/esbuild.rs Show resolved Hide resolved

Dunqing commented Sep 26, 2024

View reviewed changes

crates/oxc_codegen/tests/integration/snapshots/pure_comments.snap Show resolved Hide resolved

Dunqing mentioned this pull request Sep 26, 2024

feat(ast): allow passing span to void_0 method #6065

Merged

Dunqing force-pushed the 09-24-refactor_codegen_print_inner_comments branch from 49f34f5 to c96027a Compare September 26, 2024 05:41

github-actions bot added A-minifier Area - Minifier A-ast Area - AST A-transformer Area - Transformer / Transpiler labels Sep 26, 2024

Boshen pushed a commit that referenced this pull request Sep 26, 2024

feat(ast): allow passing span to void_0 method (#6065)

60c52ba

unblock #6021 Keep the original expression's `span` to insert comments correctly. Have tested in #6021 and it worked

Dunqing force-pushed the 09-24-refactor_codegen_print_inner_comments branch from c96027a to 3f8db9b Compare September 26, 2024 06:18

Dunqing marked this pull request as ready for review September 26, 2024 06:25

Dunqing requested a review from Boshen September 26, 2024 06:25

Boshen requested changes Sep 26, 2024

View reviewed changes

Boshen approved these changes Sep 26, 2024

View reviewed changes

Boshen added the 0-merge Merge with Graphite Merge Queue label Sep 26, 2024

feat(codegen): print vite / webpack special comments (#6021)

cca433f

Related: #1046 (comment) Close: #6024

Boshen force-pushed the 09-24-refactor_codegen_print_inner_comments branch from 15f265a to cca433f Compare September 26, 2024 15:19

graphite-app bot merged commit cca433f into main Sep 26, 2024
24 checks passed

graphite-app bot deleted the 09-24-refactor_codegen_print_inner_comments branch September 26, 2024 15:23

oxc-bot mentioned this pull request Sep 27, 2024

release(crates): v0.30.2 #6100

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(codegen): print `vite` / `webpack` special comments #6021

feat(codegen): print `vite` / `webpack` special comments #6021

Dunqing commented Sep 24, 2024 •

edited

Loading

graphite-app bot commented Sep 24, 2024

Dunqing commented Sep 24, 2024 •

edited

Loading

codspeed-hq bot commented Sep 24, 2024 •

edited

Loading

Dunqing commented Sep 26, 2024 •

edited

Loading

Boshen left a comment

Dunqing commented Sep 26, 2024

graphite-app bot commented Sep 26, 2024 •

edited

Loading

feat(codegen): print vite / webpack special comments #6021

feat(codegen): print vite / webpack special comments #6021

Conversation

Dunqing commented Sep 24, 2024 • edited Loading

graphite-app bot commented Sep 24, 2024

Your org has enabled the Graphite merge queue for merging into main

Dunqing commented Sep 24, 2024 • edited Loading

codspeed-hq bot commented Sep 24, 2024 • edited Loading

CodSpeed Performance Report

Merging #6021 will not alter performance

Summary

Dunqing commented Sep 26, 2024 • edited Loading

Boshen left a comment

Choose a reason for hiding this comment

Dunqing commented Sep 26, 2024

graphite-app bot commented Sep 26, 2024 • edited Loading

Merge activity

feat(codegen): print `vite` / `webpack` special comments #6021

feat(codegen): print `vite` / `webpack` special comments #6021

Dunqing commented Sep 24, 2024 •

edited

Loading

Dunqing commented Sep 24, 2024 •

edited

Loading

codspeed-hq bot commented Sep 24, 2024 •

edited

Loading

Dunqing commented Sep 26, 2024 •

edited

Loading

graphite-app bot commented Sep 26, 2024 •

edited

Loading