refactor(linter): use regex visitor in no-useless-escape
#6062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @camchenry and the rest of your teammates on |
This was referenced Sep 25, 2024
CodSpeed Performance ReportMerging #6062 will not alter performanceComparing Summary
|
camchenry
force-pushed
the
09-25-refactor_linter_use_regex_visitor_in_no-empty-character-class_
branch
from
c9d6086
to
9da07eb
Compare
camchenry
force-pushed
the
09-25-refactor_linter_use_regex_visitor_in_no-useless-escape_
branch
from
ed957be
to
8d137b0
Compare
camchenry
force-pushed
the
09-25-refactor_linter_use_regex_visitor_in_no-empty-character-class_
branch
from
9da07eb
to
a9b8801
Compare
camchenry
force-pushed
the
09-25-refactor_linter_use_regex_visitor_in_no-useless-escape_
branch
from
8d137b0
to
149a4f8
Compare
Boshen
force-pushed
the
09-25-refactor_linter_use_regex_visitor_in_no-empty-character-class_
branch
from
a9b8801
to
9939460
Compare
Boshen
force-pushed
the
09-25-refactor_linter_use_regex_visitor_in_no-useless-escape_
branch
from
149a4f8
to
8d280b4
Compare
Boshen
force-pushed
the
09-25-refactor_linter_use_regex_visitor_in_no-empty-character-class_
branch
2 times, most recently
from
d2d87ee
to
45b7f10
Compare
Boshen
force-pushed
the
09-25-refactor_linter_use_regex_visitor_in_no-useless-escape_
branch
from
8d280b4
to
a52fdb3
Compare
camchenry
force-pushed
the
09-25-refactor_linter_use_regex_visitor_in_no-empty-character-class_
branch
from
45b7f10
to
6e7f0a4
Compare
camchenry
force-pushed
the
09-25-refactor_linter_use_regex_visitor_in_no-useless-escape_
branch
from
a52fdb3
to
82328c7
Compare
Merge activity
|
This PR updates this rule to use the new RegExp AST visitor trait, instead of a custom implementation, which makes this rule much simpler and easier to maintain. The core logic is the same though, and the output should be identical.
Boshen
force-pushed
the
09-25-refactor_linter_use_regex_visitor_in_no-empty-character-class_
branch
from
6e7f0a4
to
eeb8873
Compare
Boshen
force-pushed
the
09-25-refactor_linter_use_regex_visitor_in_no-useless-escape_
branch
from
82328c7
to
0d44cf7
Compare
Base automatically changed from
09-25-refactor_linter_use_regex_visitor_in_no-empty-character-class_
to
main
September 27, 2024 16:03
graphite-app
bot
deleted the
09-25-refactor_linter_use_regex_visitor_in_no-useless-escape_
branch
This was referenced Oct 7, 2024
Boshen
added a commit
that referenced
this pull request
Oct 8, 2024
## [0.9.10] - 2024-10-07 ### Features - f272137 editors/vscode: Clear diagnostics on file deletion (#6326) (dalaoshu) - 1a5f293 editors/vscode: Update VSCode extention to use project's language server (#6132) (dalaoshu) - 376cc09 linter: Implement `no-throw-literal` (#6144) (dalaoshu) - 5957214 linter: Allow fixing in files with source offsets (#6197) (camchenry) - a089e19 linter: Eslint/no-else-return (#4305) (yoho) - 183739f linter: Implement prefer-await-to-callbacks (#6153) (dalaoshu) - ae539af linter: Implement no-return-assign (#6108) (Radu Baston) ### Bug Fixes - 9e9808b linter: Fix regression when parsing ts in vue files (#6336) (Boshen) - 93c6db6 linter: Improve docs and diagnostics message for no-else-return (#6327) (DonIsaac) - e0a3378 linter: Correct false positive in `unicorn/prefer-string-replace-all` (#6263) (H11) - ea28ee9 linter: Improve the fixer of `prefer-namespace-keyword` (#6230) (dalaoshu) - f6a3450 linter: Get correct source offsets for astro files (#6196) (camchenry) - be0030c linter: Allow whitespace control characters in `no-control-regex` (#6140) (camchenry) - e7e8ead linter: False positive in `no-return-assign` (#6128) (DonIsaac) ### Performance - ac0a82a linter: Reuse allocator when there are multiple source texts (#6337) (Boshen) - 50a0029 linter: Do not concat vec in `no-useless-length-check` (#6276) (camchenry) ### Documentation - 7ca70dd linter: Add docs for `ContextHost` and `LintContext` (#6272) (camchenry) - a949ecb linter: Improve docs for `eslint/getter-return` (#6229) (DonIsaac) - 14ba263 linter: Improve docs for `eslint-plugin-import` rules (#6131) (dalaoshu) ### Refactor - 642725c linter: Rename vars from `ast_node_id` to `node_id` (#6305) (overlookmotel) - 8413175 linter: Move shared function from utils to rule (#6127) (dalaoshu) - ba9c372 linter: Make jest/vitest rule mapping more clear (#6273) (camchenry) - 82b8f21 linter: Add schemars and serde traits to AllowWarnDeny and RuleCategories (#6119) (DonIsaac) - ea908f7 linter: Consolidate file loading logic (#6130) (DonIsaac) - db751f0 linter: Use regexp AST visitor in `no-control-regex` (#6129) (camchenry) - 3aa7e42 linter: Use RegExp AST visitor for `no-hex-escape` (#6117) (camchenry) - 9d5b44a linter: Use regex visitor in `no-regex-spaces` (#6063) (camchenry) - 0d44cf7 linter: Use regex visitor in `no-useless-escape` (#6062) (camchenry) - eeb8873 linter: Use regex visitor in `no-empty-character-class` (#6058) (camchenry) ### Testing - d883562 linter: Invalid `eslint/no-unused-vars` options (#6228) (DonIsaac) --------- Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates this rule to use the new RegExp AST visitor trait, instead of a custom implementation, which makes this rule much simpler and easier to maintain. The core logic is the same though, and the output should be identical.