Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(linter): improve docs for node/security/tree_shaking rules #6097

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

shulaoda
Copy link
Contributor

@shulaoda shulaoda commented Sep 27, 2024

Related to #6050

As of this PR, all documents of that contain a few rules have been corrected.

Copy link

graphite-app bot commented Sep 27, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the A-linter Area - Linter label Sep 27, 2024
Copy link

codspeed-hq bot commented Sep 27, 2024

CodSpeed Performance Report

Merging #6097 will not alter performance

Comparing shulaoda:docs/node-security-tree_shaking (c5b7dc5) with main (418ae25)

Summary

✅ 29 untouched benchmarks

@camchenry camchenry added the 0-merge Merge with Graphite Merge Queue label Sep 27, 2024
Copy link

graphite-app bot commented Sep 27, 2024

Merge activity

  • Sep 26, 11:54 PM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Sep 26, 11:54 PM EDT: camchenry added this pull request to the Graphite merge queue.
  • Sep 26, 11:55 PM EDT: The Graphite merge queue couldn't merge this PR because it failed for an unknown reason.
  • Sep 27, 2:28 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Sep 27, 2:28 AM EDT: Boshen added this pull request to the Graphite merge queue.
  • Sep 27, 2:29 AM EDT: The Graphite merge queue couldn't merge this PR because it failed for an unknown reason (Stack merges are not currently supported for forked repositories. Please create a branch in the target repository in order to merge).

@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Sep 27, 2024
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Sep 27, 2024
@Boshen Boshen merged commit d4bed9a into oxc-project:main Sep 27, 2024
28 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Sep 27, 2024
@shulaoda shulaoda deleted the docs/node-security-tree_shaking branch September 27, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants