Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(wasm): remove type defs for ArrayExpressionElement and Elision #6683

Merged
merged 1 commit into from
Oct 20, 2024
Merged

fix(wasm): remove type defs for ArrayExpressionElement and Elision #6683

merged 1 commit into from
Oct 20, 2024

Commits on Oct 20, 2024

  1. fix(wasm): remove type defs for ArrayExpressionElement and Elision ( 

    #6683)

Follow-on after #6404.

`ArrayExpressionElement` and `Elision` are not used in the TS types, because `ArrayExpression` has an override for the field it uses.

https://github.com/oxc-project/oxc/blob/002289b4b1b0d6fac080c4b12f4939c8f455272f/crates/oxc_ast/src/ast/js.rs#L293-L302

Prevent these TS type defs being emitted by introducing a new `#[estree(custom_ts_def)]` attr, to go with `#[estree(custom_serialize)]`.
    @overlookmotel
    overlookmotel committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    53049fe View commit details
    Browse the repository at this point in the history