feat(linter): add `oxc/no-map-spread` #6751

DonIsaac · 2024-10-21T17:20:14Z

Adds a new performance rule that disallows using object and array spreads in map and flatMap to modify/merge arrays and objects.
I've currently added it to nursery so we can battle-harden it before making it generally available as a perf rule.

// needless O(n) spread on `x`, making this an O(n^2) operation
const x = arr.map(x => {
  return { ...x, foo: getFoo(x.id) }
})

// Object.assign is better here
const x = arr.map(x => {
  return Object.assign(x, { foo: getFoo(x.id) })
})

graphite-app · 2024-10-21T17:20:19Z

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

DonIsaac · 2024-10-21T17:20:31Z

feat(linter): add oxc/no-map-spread #6751 👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @DonIsaac and the rest of your teammates on Graphite

codspeed-hq · 2024-10-21T17:27:06Z

CodSpeed Performance Report

Merging #6751 will not alter performance

_{Comparing don/10-21-feat_linter_add_oxc/no-map-spread_ (1e2f012) with main (1c66473)}

Summary

✅ 30 untouched benchmarks

camc314

this looks great.

crates/oxc_linter/src/rules/oxc/no_map_spread.rs

camc314

this looks good to me - there's some dead code that could be removed.

i also wonder whether it's worth either:
a. SpreadInReturnVisitor::<'a, '_>::iter_spreads converting this to follow the same pat as no_accumulating_spread to fine spreads
b. converting no_accumulating spread to use SpreadInReturnVisitro

crates/oxc_linter/src/rules/oxc/no_map_spread.rs

crates/oxc_linter/src/snapshots/no_map_spread.snap

mysteryven

LGTM

crates/oxc_linter/src/rules/oxc/no_map_spread.rs

DonIsaac · 2024-10-26T17:40:11Z

Merge activity

Oct 26, 1:40 PM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Oct 26, 1:40 PM EDT: A user added this pull request to the Graphite merge queue.
Oct 26, 1:47 PM EDT: A user merged this pull request with the Graphite merge queue.

Adds a new performance rule that disallows using object and array spreads in `map` and `flatMap` to modify/merge arrays and objects. I've currently added it to `nursery` so we can battle-harden it before making it generally available as a `perf` rule. ```ts // needless O(n) spread on `x`, making this an O(n^2) operation const x = arr.map(x => { return { ...x, foo: getFoo(x.id) } }) // Object.assign is better here const x = arr.map(x => { return Object.assign(x, { foo: getFoo(x.id) }) }) ```

## [0.11.0] - 2024-11-03 - 9fd9f4f linter: [**BREAKING**] Sync sindresorhus/globals; removed Object.prototype properties from builtin and es* globals (#6991) (Boshen) ### Features - 6b619da editor: Listen to config file changes and trigger a didChangeConfiguration update (#6964) (Nicholas Rayburn) - 7872927 editor/vscode: Support window/showMessage event (#7085) (Nicholas Rayburn) - 2184588 linter: Do not bail for unmatched rules yet (#7093) (Boshen) - a6fcd81 linter: Add `import/no-commonjs` rule (#6978) (Dmitry Zakharov) - 1691cab linter: Support user-configurable secrets for `oxc-security/api-keys` (#5938) (DonIsaac) - 610621c linter: Implement `react/style-prop-object` (#6342) (Albert Kaaman) - 1e2f012 linter: Add `oxc/no-map-spread` (#6751) (DonIsaac) - 1c66473 linter: Implement `eslint/prefer-object-has-own` (#6905) (tomoya yanagibashi) ### Bug Fixes - ebf3753 editor: Fix onConfigChange to send the correct config for didChangeConfiguration notification (#6962) (Nicholas Rayburn) - 79bf74a linter: Check is_reference_to_global_variable in `no-array-constructor` (#7067) (Naoya Yoshizawa) - 38d1f78 linter: Remove confusing help text for now (#7081) (Cam McHenry) - 147e2e4 linter: Allow replacing rule when none are enabled yet (#7014) (camchenry) - 7aa496a linter: Remove unsafe fixer of `no-useless-spread` (#6655) (dalaoshu) - f5a7134 linter/no-unused-vars: False positive for discarded reads within sequences (#6907) (DonIsaac) ### Documentation - 4551baa linter: Document `rules` (#6983) (Boshen) ### Refactor - a8dc75d linter: Remove unused CLI result types (#7088) (camchenry) - 8f1460e linter: Move `LintPlugins` from `LintOptions` to `LintConfig` (#6932) (DonIsaac) ### Testing - c35d3f2 linter: Improve test failure output (#6975) (camchenry) --------- Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

## [0.35.0] - 2024-11-04 - f543a8d ast: [**BREAKING**] Remove `AstBuilder::*_from_*` methods (#7073) (overlookmotel) - b8daab3 transformer: [**BREAKING**] API to `TryFrom<&EnvOptions> for TransformOptions` and `TryFrom<&BabelOptions> TransformOptions` (#7020) (Boshen) - 9a6a2f9 semantic: [**BREAKING**] Remove `SymbolTable::get_symbol_id_from_span` API (#6955) (Boshen) ### Features - 854870e ast: Label AST fields with #[ts] (#6987) (ottomated) - ce5b609 ast: Remove explicit untagged marker on enums (#6915) (ottomated) - 9725e3c ast_tools: Add #[estree(always_flatten)] to Span (#6935) (ottomated) - fbc297e ast_tools: Move tsify custom types to estree attribute macro (#6934) (ottomated) - 169fa22 ast_tools: Default enums to rename_all = "camelCase" (#6933) (ottomated) - caa4b1f codegen: Improve printing of comments (#7108) (Boshen) - 001058a codegen: Always print legal comments on its own line (#7089) (Boshen) - 413973d codegen: Print linked and external legal comment (#7059) (Boshen) - ee27b92 codegen: Print eof legal comments (#7058) (Boshen) - 6516f9e codegen: Print inline legal comments (#7054) (Boshen) - 1e2f012 linter: Add `oxc/no-map-spread` (#6751) (DonIsaac) - 6d97af4 rust: Use `oxc-miette` (#6938) (Boshen) - bfdbcf1 transformer: Add `EnvOptions::from_browerslist_query` API (#7098) (Boshen) - 21b8e49 transformer: Add `ESTarget` (#7091) (Boshen) - fcaba4a transformer: Add `TransformerOptions::env` with `EnvOptions` (#7037) (Boshen) - 1d906c6 transformer: Class properties transform skeleton (#7038) (overlookmotel) - 934cb5e transformer: Add `async_generator_functions` plugin (#6573) (Dunqing) ### Bug Fixes - 0601271 ast: Fix `StaticMemberExpression.get_first_object` (#6969) (tomoya yanagibashi) - da199c7 ecmascript: Allow getting PropName for object methods (#6967) (camchenry) - f5a7134 linter/no-unused-vars: False positive for discarded reads within sequences (#6907) (DonIsaac) - 9ed9501 module_lexer: Add missing `export * from 'foo';` case (#7103) (Boshen) - d15e408 napi/transform: Fix 'typescript.declaration' option not working (#7012) (Boshen) - dcdb9ea napi/transform: Fix test (Boshen) - caaf00e parser: Fix incorrect parsed `TSIndexSignature` (#7016) (Boshen) - b188b4a transformer: Fix typescript globals being recognized as globals (#7100) (Boshen) - a2244ff transformer/async-to-generator: Output is incorrect when arrow function without params (#7052) (Dunqing) - 7d12669 types: Move @oxc-project/types to dependencies (#6909) (ottomated) ### Performance - 6ca01b9 ast: Reduce size of `Comment` (#6921) (overlookmotel) - c58ec89 data_structures: Optimize `NonEmptyStack::pop` (#7021) (overlookmotel) - fa9a4ec parser: Check `.` before `[` in `parse_member_expression_rest` (#6979) (Boshen) ### Refactor - b0211a1 ast: `StaticMemberExpression::get_first_object` use loop instead of recursion (#7065) (overlookmotel) - fc07458 ast: Move custom types `.d.ts` file (#6931) (overlookmotel) - c41c013 ast: Rename lifetime (#6922) (overlookmotel) - 335eb38 ast_tools: Faster formatting Rust code (#6972) (overlookmotel) - 4cf0085 ast_tools: Reorder imports in generated code (#6926) (overlookmotel) - dd79c1b codegen: Replace `daachorse` with string match for annotation comment (#7064) (Boshen) - 0bb1aa4 codegen: Move options to its own file (#7053) (Boshen) - b021147 data_structures: Make all methods of `NonNull` shim `#[inline(always)]` (#7024) (overlookmotel) - fb1710a data_structures: Add `#[repr(transparent)]` to `NonNull` shim (#7023) (overlookmotel) - f1fc8db data_structures: Add `read` method to `NonNull` shim (#7022) (overlookmotel) - cea0e6b isolated_declarations: Do not use `AstBuilder::*_from_*` methods (#7071) (overlookmotel) - 97caae1 minifier: Do not use `AstBuilder::*_from_*` methods (#7072) (overlookmotel) - 2c7ac29 minifier: Remove `Tri`, use `Option<bool>` instead (#6912) (Boshen) - 9926990 napi: Move custom types to bottom of file (#6930) (overlookmotel) - 23157bd napi: Types file in root of types package (#6929) (overlookmotel) - 953b051 parser: Remove `oxc_ecmascript` crate (#7109) (Boshen) - fdd480d parser: Do not use `AstBuilder::*_from_*` methods (#7068) (overlookmotel) - 9e85b10 parser: Add `ParserImpl::alloc` method (#7063) (overlookmotel) - 17a938e parser: Use function `parse_type_member_semicolon` (#7018) (Boshen) - aa1b29c parser: Remove `parse_ts_index_signature_member` function (#7017) (Boshen) - 7f1d1fe transform: Deserialize `BabelPreests::env` directly (#7051) (Boshen) - 76947e2 transform: Refactor Babel Targets (#7026) (Boshen) - d03e622 transformer: Do not use `AstBuilder::*_from_*` methods (#7070) (overlookmotel) - 9d384ad transformer: Use `identifier_reference_with_reference_id` builder method (#7056) (overlookmotel) - 4688a06 transformer: Use `*_with_scope_id` builder methods where possible (#7055) (overlookmotel) - 7122e00 transformer: Use `ctx.alloc` over `ctx.ast.alloc` where possible (#7066) (overlookmotel) - a3b68b4 transformer: Flatten dir structure of options/babel/env (#7049) (Boshen) - 6d92f36 transformer: Deserialize `BabelOptions::compiler_assumptions` (#7048) (Boshen) - f83a760 transformer: Deserialize `BabelOptions::presets` (#7047) (Boshen) - 52c20d6 transformer: Deserialize `BabelOptions::plugins` (#7045) (Boshen) - e921df6 transformer: Rename `EnvOptions` to `BabelEnvOptions` (#7036) (Boshen) - af5140f transformer: Isolate babel options logic (#7034) (Boshen) - 12aa910 transformer: Clean up `env/targets/query.rs` (#7033) (Boshen) - 3d174bb transformer: Clean up `BabelOptions` (#7029) (Boshen) - 6284f84 transformer: Use `Browserslist::Version` (#7028) (Boshen) - 5b11cdf transformer: Clean up TransformerOptions (#7005) (Boshen) - f0c87d4 transformer: Mark all EnvOptions as not implemented (#7004) (Boshen) - d9edef6 transformer: Combine ObjectRestSpread into a single file (#7002) (Boshen) - c945fe7 transformer: Import `oxc_allocator::Box` as `ArenaBox` (#6999) (overlookmotel) - fc1af2e transformer: Import `oxc_allocator::Vec` as `ArenaVec` (#6998) (overlookmotel) - 63e8bfe transformer: Rename `AString` to `ArenaString` (#6997) (overlookmotel) - 562bb9a transformer/async-to-generator: Move transform methods to `AsyncGeneratorExecutor` and make it public (#6992) (Dunqing) - e23f7e6 transformer/common: `VarDeclarations` insert either `var` or `let` statements (#7043) (overlookmotel) - e5ecbb9 transformer/jsx: Return `&mut T` not `&mut ArenaBox<T>` (#7001) (overlookmotel) - 9e66c29 transformer/react-refresh: Small refactor (#6973) (overlookmotel) - 1ca8cd2 transformer/react-refresh: Avoid panic for `init` of `VariableDeclarator` isn't a `BindingIdentifier` (#6937) (Dunqing) - 5f153ac transformer/react-refresh: Use `VarDeclarations` to insert declarators (#6884) (Dunqing) - df3b089 transformer/react-refresh: Use `StatementInjector` to insert statements (#6881) (Dunqing) - ae22671 transformer/typescript: Pass `&mut T` not `&mut ArenaBox<T>` (#7000) (overlookmotel) - 938ee87 traverse: Do not use `AstBuilder::*_from_*` methods (#7069) (overlookmotel) ### Styling - 86ab091 transformer/common: Split up `StatementInjectorStore` methods into blocks (#7042) (overlookmotel) ### Testing - 64e2499 module_lexer: Use a single integration test for faster compilation (#7097) (Boshen) - 6133a50 transformer: Use a single integration test for faster compilation (#7099) (Boshen) --------- Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

github-actions bot added A-linter Area - Linter C-enhancement Category - New feature or request labels Oct 21, 2024

DonIsaac requested review from camc314, camchenry and mysteryven October 21, 2024 17:23

camc314 reviewed Oct 21, 2024

View reviewed changes

DonIsaac force-pushed the don/10-21-feat_linter_add_oxc/no-map-spread_ branch from 4eb3208 to 138b4e5 Compare October 21, 2024 18:45

DonIsaac requested a review from camc314 October 21, 2024 18:46

camc314 reviewed Oct 21, 2024

View reviewed changes

crates/oxc_linter/src/rules/oxc/no_map_spread.rs Show resolved Hide resolved

camc314 reviewed Oct 21, 2024

View reviewed changes

crates/oxc_linter/src/rules/oxc/no_map_spread.rs Outdated Show resolved Hide resolved

camc314 reviewed Oct 21, 2024

View reviewed changes

crates/oxc_linter/src/rules/oxc/no_map_spread.rs Outdated Show resolved Hide resolved

camc314 approved these changes Oct 21, 2024

View reviewed changes

DonIsaac force-pushed the don/10-21-feat_linter_add_oxc/no-map-spread_ branch 3 times, most recently from f544b5b to 6bcb558 Compare October 21, 2024 22:05

camchenry reviewed Oct 22, 2024

View reviewed changes

mysteryven reviewed Oct 22, 2024

View reviewed changes

DonIsaac commented Oct 24, 2024

View reviewed changes

crates/oxc_linter/src/rules/oxc/no_map_spread.rs Show resolved Hide resolved

DonIsaac force-pushed the don/10-21-feat_linter_add_oxc/no-map-spread_ branch 4 times, most recently from 6efc42a to d2654c4 Compare October 24, 2024 17:33

overlookmotel mentioned this pull request Oct 25, 2024

ast: get arena-lifetime references to AST children #6873

Closed

Boshen self-assigned this Oct 25, 2024

DonIsaac force-pushed the don/10-21-feat_linter_add_oxc/no-map-spread_ branch 3 times, most recently from e4beef8 to cb83de2 Compare October 25, 2024 21:13

github-actions bot added the A-ast Area - AST label Oct 25, 2024

DonIsaac force-pushed the don/10-21-feat_linter_add_oxc/no-map-spread_ branch from cb83de2 to fd3e6ca Compare October 25, 2024 23:20

DonIsaac marked this pull request as ready for review October 25, 2024 23:20

DonIsaac requested review from camchenry and mysteryven October 25, 2024 23:26

mysteryven approved these changes Oct 26, 2024

View reviewed changes

DonIsaac force-pushed the don/10-21-feat_linter_add_oxc/no-map-spread_ branch 2 times, most recently from 1d9714c to bcd2abd Compare October 26, 2024 17:28

DonIsaac added the 0-merge Merge with Graphite Merge Queue label Oct 26, 2024

DonIsaac force-pushed the don/10-21-feat_linter_add_oxc/no-map-spread_ branch from bcd2abd to 1e2f012 Compare October 26, 2024 17:41

graphite-app bot merged commit 1e2f012 into main Oct 26, 2024
27 checks passed

graphite-app bot deleted the don/10-21-feat_linter_add_oxc/no-map-spread_ branch October 26, 2024 17:47

oxc-bot mentioned this pull request Nov 3, 2024

release(oxlint): v0.11.0 #7094

Merged

oxc-bot mentioned this pull request Nov 4, 2024

release(crates): v0.35.0 #7110

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(linter): add `oxc/no-map-spread` #6751

feat(linter): add `oxc/no-map-spread` #6751

DonIsaac commented Oct 21, 2024 •

edited

Loading

graphite-app bot commented Oct 21, 2024

DonIsaac commented Oct 21, 2024

codspeed-hq bot commented Oct 21, 2024 •

edited

Loading

camc314 left a comment

camc314 left a comment

mysteryven left a comment

DonIsaac commented Oct 26, 2024 •

edited by graphite-app bot

Loading

feat(linter): add oxc/no-map-spread #6751

feat(linter): add oxc/no-map-spread #6751

Conversation

DonIsaac commented Oct 21, 2024 • edited Loading

graphite-app bot commented Oct 21, 2024

Your org has enabled the Graphite merge queue for merging into main

DonIsaac commented Oct 21, 2024

codspeed-hq bot commented Oct 21, 2024 • edited Loading

CodSpeed Performance Report

Merging #6751 will not alter performance

Summary

camc314 left a comment

Choose a reason for hiding this comment

camc314 left a comment

Choose a reason for hiding this comment

mysteryven left a comment

Choose a reason for hiding this comment

DonIsaac commented Oct 26, 2024 • edited by graphite-app bot Loading

Merge activity

feat(linter): add `oxc/no-map-spread` #6751

feat(linter): add `oxc/no-map-spread` #6751

DonIsaac commented Oct 21, 2024 •

edited

Loading

codspeed-hq bot commented Oct 21, 2024 •

edited

Loading

DonIsaac commented Oct 26, 2024 •

edited by graphite-app bot

Loading