refactor(linter): impl Deref<Target = Semantic> for LintContext
#6752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
the
C-cleanup
CodSpeed Performance ReportMerging #6752 will not alter performanceComparing Summary
|
camc314
approved these changes
Oct 21, 2024
Merge activity
|
…6752) `LintContext` contains many wrapper methods that invoke a method with the same name on `Semantic`. Implementing `Deref` lets us remove those redundant methods.
DonIsaac
force-pushed
the
don/10-21-refactor_linter_impl_deref_target_semantic_for_lintcontext_
branch
from
43658a7 to
744aa74
Compare
graphite-app
bot
deleted the
don/10-21-refactor_linter_impl_deref_target_semantic_for_lintcontext_
branch
Boshen
added a commit
that referenced
this pull request
Oct 22, 2024
## [0.10.2] - 2024-10-22 ### Features - dbe1972 linter: Import/no-cycle should turn on ignore_types by default (#6761) (Boshen) - 619d06f linter: Fix suggestion for `eslint:no_empty_static_block` rule (#6732) (Tapan Prakash) ### Bug Fixes ### Performance - 8387bac linter: Apply small file optimization, up to 30% faster (#6600) (camchenry) ### Refactor - b884577 linter: All ast_util functions take Semantic (#6753) (DonIsaac) - 744aa74 linter: Impl `Deref<Target = Semantic>` for `LintContext` (#6752) (DonIsaac) - 6ffdcc0 oxlint: Lint/mod.rs -> lint.rs (#6746) (Boshen) ### Testing - b03cec6 oxlint: Add `--fix` test case (#6747) (Boshen) --------- Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LintContextcontains many wrapper methods that invoke a method with the samename on
Semantic. ImplementingDereflets us remove those redundant methods.