Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(linter): warn unmatched rule names #6782

Merged
merged 3 commits into from
Oct 23, 2024
Merged

feat(linter): warn unmatched rule names #6782

merged 3 commits into from
Oct 23, 2024

Conversation

tapanprakasht
Copy link
Contributor

Fixes #6763

@graphite-app Graphite App
Copy link

graphite-app bot commented Oct 22, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-linter Area - Linter C-enhancement Category - New feature or request labels Oct 22, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Oct 22, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #6782 will not alter performance

Comparing tapanprakasht:print-unsupported-rules (0bcc3ad) with main (ffa3945)

Summary

✅ 30 untouched benchmarks

DonIsaac
DonIsaac previously requested changes Oct 22, 2024
View reviewed changes
crates/oxc_linter/src/config/rules.rs Show resolved Hide resolved
Boshen
Boshen requested changes Oct 23, 2024
View reviewed changes
Copy link
Member

@Boshen Boshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using OxcDiagnostic::warn and the reporter instead of directly printing to stdout.

Boshen
Boshen approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@Boshen Boshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge and iterate.

@Boshen Boshen merged commit 2aa763c into oxc-project:main Oct 23, 2024
27 checks passed
@oxc-bot oxc-bot mentioned this pull request Oct 26, 2024
Merged
Boshen added a commit that referenced this pull request Oct 26, 2024
@oxc-bot @Boshen @autofix-ci
release(oxlint): v0.10.3 (#6911)
1ea0be1 
## [0.10.3] - 2024-10-26

- 90c786c regular_expression: [**BREAKING**] Support ES2025 Duplicated
named capture groups (#6847) (leaysgur)

- 8032813 regular_expression: [**BREAKING**] Migrate to new regexp
parser API (#6741) (leaysgur)

### Features

- a73c5af linter: Add fixer for `jsx-a11y/no-access-key` rule (#6781)
(Tapan Prakash)
- 2aa763c linter: Warn unmatched rule names (#6782) (Tapan Prakash)
- 0acca58 linter: Support `--print-config all` to print config file for
project (#6579) (mysteryven)

### Bug Fixes

- f49b3e2 linter: `react/iframe-missing-sandbox` ignores vanilla JS APIs
(#6872) (DonIsaac)
- 54a5032 linter: Correct false positive in `no-duplicates` (#6748)
(dalaoshu)
- a47c70e minifier: Fix remaining runtime bugs (#6855) (Boshen)

### Documentation

- 3923e63 linter: Add schema to config examples (#6838) (Dmitry
Zakharov)

### Refactor

- a148023 linter: Dereference IDs as soon as possible (#6821)
(overlookmotel)
- 423d54c rust: Remove the annoying `clippy::wildcard_imports` (#6860)
(Boshen)

---------

Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Orenbek pushed a commit to Orenbek/oxc that referenced this pull request Oct 28, 2024
@oxc-bot @Boshen
@autofix-ci @Orenbek
release(oxlint): v0.10.3 (oxc-project#6911)
dbee731 
## [0.10.3] - 2024-10-26

- 90c786c regular_expression: [**BREAKING**] Support ES2025 Duplicated
named capture groups (oxc-project#6847) (leaysgur)

- 8032813 regular_expression: [**BREAKING**] Migrate to new regexp
parser API (oxc-project#6741) (leaysgur)

### Features

- a73c5af linter: Add fixer for `jsx-a11y/no-access-key` rule (oxc-project#6781)
(Tapan Prakash)
- 2aa763c linter: Warn unmatched rule names (oxc-project#6782) (Tapan Prakash)
- 0acca58 linter: Support `--print-config all` to print config file for
project (oxc-project#6579) (mysteryven)

### Bug Fixes

- f49b3e2 linter: `react/iframe-missing-sandbox` ignores vanilla JS APIs
(oxc-project#6872) (DonIsaac)
- 54a5032 linter: Correct false positive in `no-duplicates` (oxc-project#6748)
(dalaoshu)
- a47c70e minifier: Fix remaining runtime bugs (oxc-project#6855) (Boshen)

### Documentation

- 3923e63 linter: Add schema to config examples (oxc-project#6838) (Dmitry
Zakharov)

### Refactor

- a148023 linter: Dereference IDs as soon as possible (oxc-project#6821)
(overlookmotel)
- 423d54c rust: Remove the annoying `clippy::wildcard_imports` (oxc-project#6860)
(Boshen)

---------

Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Boshen Boshen Boshen approved these changes

@DonIsaac DonIsaac DonIsaac left review comments

Assignees
No one assigned
Labels
A-linter Area - Linter C-enhancement Category - New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

linter: warn unmatched rule names
3 participants
@tapanprakasht @Boshen @DonIsaac