refactor(ast_tools): remove const params for Visit generator
#6927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @overlookmotel and the rest of your teammates on |
This was referenced Oct 26, 2024
github-actions
bot
added
A-ast-tools
Merge activity
|
This function is large, so const param here was probably making the code slower, certainly slower compile time. Use a runtime value instead.
overlookmotel
force-pushed
the
10-26-refactor_ast_tools_reorder_imports_in_generated_code
branch
from
7bd9a06
to
4cf0085
Compare
overlookmotel
force-pushed
the
10-26-refactor_ast_tools_remove_const_params_for_visit_generator
branch
from
75a31c9
to
ad40ab7
Compare
Base automatically changed from
10-26-refactor_ast_tools_reorder_imports_in_generated_code
to
main
October 26, 2024 14:13
graphite-app
bot
deleted the
10-26-refactor_ast_tools_remove_const_params_for_visit_generator
branch
Orenbek
pushed a commit
to Orenbek/oxc
that referenced
this pull request
Oct 28, 2024
…roject#6927) This function is large, so const param here was probably making the code slower, certainly slower compile time. Use a runtime value instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function is large, so const param here was probably making the code slower, certainly slower compile time. Use a runtime value instead.