Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(traverse): add methods for creating Expression::Identifiers #7301

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

overlookmotel
Copy link
Collaborator

@overlookmotel overlookmotel commented Nov 15, 2024

It's a common pattern in transformer to call ctx.create_ident_reference() and then convert to an Expression with Expression::Identifier(ctx.ast.alloc(ident)).

Add methods to do this in a single method call.

Copy link

graphite-app bot commented Nov 15, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the A-transformer Area - Transformer / Transpiler label Nov 15, 2024
@github-actions github-actions bot added the C-enhancement Category - New feature or request label Nov 15, 2024
@overlookmotel overlookmotel marked this pull request as ready for review November 15, 2024 17:16
Copy link

codspeed-hq bot commented Nov 15, 2024

CodSpeed Performance Report

Merging #7301 will not alter performance

Comparing 11-15-feat_traverse_add_methods_for_creating_expression_identifier_s (6e7d767) with main (1cbc624)

Summary

✅ 30 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-transformer Area - Transformer / Transpiler C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant