fix(linter): false positive in jsx-a11y/label-has-associated-control
#7881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
CodSpeed Performance ReportMerging #7881 will not alter performanceComparing Summary
|
|
I think it should if makes sense. |
Boshen
pushed a commit
that referenced
this pull request
Dec 14, 2024
#7885) I think it should if makes sense. _Originally posted by @Boshen in #7881 (comment) Since `jsx-a11y` supports these names, I have aligned them accordingly.
Boshen
added a commit
that referenced
this pull request
Dec 17, 2024
## [0.15.3] - 2024-12-17 ### Features - 25ddb35 linter: Add the import/no_named_default rule (#7902) (Guillaume Piedigrossi) - ee26b44 linter: Enhance `get_element_type` to resolve more element types (#7885) (dalaoshu) ### Bug Fixes - 6f41d92 linter: False positive in `unicorn/no-useless-spread` (#7940) (dalaoshu) - 0867b40 linter: Fix configuration parser for `no-restricted-imports` (#7921) (Alexander S.) - 9c9b73d linter: Fix incorrect fixer for `prefer-regexp-test` (#7898) (Cameron) - 32935e6 linter: False positive in `jsx-a11y/label-has-associated-control` (#7881) (dalaoshu) - 14c51ff semantic: Remove inherting `ScopeFlags::Modifier` from parent scope (#7932) (Dunqing) ### Refactor - 3858221 global: Sort imports (#7883) (overlookmotel) - b99ee37 linter: Move rule "no-restricted-imports" to nursery (#7897) (Alexander S.) - ff2a68f linter/yoda: Simplify code (#7941) (overlookmotel) ### Styling - 7fb9d47 rust: `cargo +nightly fmt` (#7877) (Boshen) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #7849
This is essentially because
get_element_typedoes not support recognizing tag names like<a.b />. I'm unsure whether we should support it.