fix(semantic): reset references flags when resolved #7923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Performance ReportMerging #7923 will degrade performances by 3.06%Comparing Summary
Benchmarks breakdown
|
Dunqing
force-pushed
the
12-16-fix_semantic_reset_references_flags_when_resolved
branch
from
b49caf3 to
e56f576
Compare
Merge activity
|
Boshen
force-pushed
the
12-15-test_transformer_move_named_test_to_exports_folder
branch
from
0f0d8cc to
7dc483a
Compare
Boshen
pushed a commit
that referenced
this pull request
Dec 16, 2024
For this case, we set `current_reference_flags` to `ReferenceFlags::Type` for `TSInterfaceHeritage`, but never unset it, which causes resolving `fowardRef` identifier reuse `current_reference_flags` of `TSInterfaceHeritage`.
```ts
import { forwardRef } from "react";
export interface MenuTriggerProps extends Object {}
export const MenuTrigger = forwardRef();
```
In this PR, reset the `current_reference_flags` when resolved, so that we don't need to reset it in individual visit functions. This is a reasonable change because the `current_reference_flags` only applies to the next encountered identifier.
Boshen
force-pushed
the
12-16-fix_semantic_reset_references_flags_when_resolved
branch
from
e56f576 to
dec5fb1
Compare
For this case, we set `current_reference_flags` to `ReferenceFlags::Type` for `TSInterfaceHeritage`, but never unset it, which causes resolving `fowardRef` identifier reuse `current_reference_flags` of `TSInterfaceHeritage`.
```ts
import { forwardRef } from "react";
export interface MenuTriggerProps extends Object {}
export const MenuTrigger = forwardRef();
```
In this PR, reset the `current_reference_flags` when resolved, so that we don't need to reset it in individual visit functions. This is a reasonable change because the `current_reference_flags` only applies to the next encountered identifier.
Boshen
force-pushed
the
12-15-test_transformer_move_named_test_to_exports_folder
branch
from
7dc483a to
523d48c
Compare
Boshen
force-pushed
the
12-16-fix_semantic_reset_references_flags_when_resolved
branch
from
dec5fb1 to
596aead
Compare
Base automatically changed from
12-15-test_transformer_move_named_test_to_exports_folder
to
main
December 16, 2024 02:37
graphite-app
bot
deleted the
12-16-fix_semantic_reset_references_flags_when_resolved
branch
Dunqing
added a commit
that referenced
this pull request
Dec 18, 2024
## [0.42.0] - 2024-12-18 - 84b75a0 semantic: [**BREAKING**] Remove `ScopeFlags::Modifiers` (#7935) (overlookmotel) - c071494 semantic: [**BREAKING**] Remove `SymbolTable::rename` method (#7868) (overlookmotel) ### Features - 8b7c5ae ast: Add `AstBuilder::atom_from_cow` (#7974) (overlookmotel) - 46e2e27 data_structures: Implement `Default` for `NonEmptyStack` (#7946) (overlookmotel) - db9e93b mangler: Mangle top level variables (#7907) (翠 / green) - 075bd16 minifier: Fold bitwise operation (#7908) (翠 / green) - c16a851 napi/transform: Add `jsx: 'preserve'` option (#7965) (Boshen) - 81eedb1 parser: 'readonly' type modifier is only permitted on array and tuple literal types. (#7880) (Boshen) - b9322c6 semantic: Re-export all flags and ID types (#7886) (overlookmotel) - c30a982 span: Add `impl From<ArenaString> for Atom` (#7973) (overlookmotel) - 02b653c transformer/class-properties: Do not create temp var for template literal computed key (#7919) (overlookmotel) - feac02e transformer/class-properties: Only rename symbols if necessary (#7896) (overlookmotel) - 6bc530d transformer/class-properties: Transform super call expression that is inside static prop initializer (#7831) (Dunqing) - 53e2bc0 traverse: Add `TraverseScoping::rename_symbol` method (#7871) (overlookmotel) ### Bug Fixes - 3659e6d cfg: Include export default code in CFG instructions (#7862) (Jan Olaf Martin) - 850dd43 codegen: Missing `,` when generating type parameters with jsx (#7929) (Dunqing) - 4799471 minfier: Bigint bitwise operation only works with bigint (#7937) (Boshen) - de8a86e minifier: Incorrect minification in `try_fold_left_child_op` (#7949) (翠 / green) - 9a30910 oxc_transformer: Inject_global_variables should considering string imported name (#7768) (IWANABETHATGUY) - 111dc52 parser: Include export token in spans of TSNamespaceExportDeclaration (#7963) (branchseer) - 14c51ff semantic: Remove inherting `ScopeFlags::Modifier` from parent scope (#7932) (Dunqing) - 596aead semantic: Reset references flags when resolved (#7923) (Dunqing) - 4924073 semantic: `ScopeTree::rename_binding` preserve order of bindings (#7870) (overlookmotel) - bb38065 transformer/class-properties: Do not transform `super.prop` in nested method within static prop initializer (#7978) (overlookmotel) - e76fbb0 transformer/class-properties: Fix symbol clashes in instance prop initializers (#7872) (overlookmotel) - c0576fa transformer/class-properties: Use UID for `args` in created class constructor (#7866) (overlookmotel) - d660d8d transformer/optional-chaining: Do not create unused reference when `noDocumentAll` assumption (#7847) (overlookmotel) - 4920c6a transformer/optional-chaining: Avoid creating a useless reference when `noDocumentAll` is true (#7832) (Dunqing) ### Performance - a5f04a7 ast: Faster `Comment::is_jsdoc` (#7905) (overlookmotel) - 4b24335 codegen: Improve printing of statement comments (#7857) (Boshen) - 71a40a2 codegen: Guard comment printing comments when there are no comments (#7856) (Boshen) - b31f123 transformer/class-properties: Do not re-generate same method key (#7915) (overlookmotel) - 8ca8fce transformer/class-properties: Reduce work updating scopes when transforming static prop initializers (#7904) (overlookmotel) - 80d0b3e transformer/class-properties: Fast path for instance prop initializer scope re-parenting (#7901) (overlookmotel) - 38aafa2 transformer/class-properties: Reduce size of `transform_call_expression_for_super_member_expr` (#7859) (overlookmotel) ### Documentation - e49de81 ast: Document `Expression::is_*` methods (#7853) (overlookmotel) - 10a86b9 transformer: Fix comments (#7925) (overlookmotel) - f4cb5d3 transformer: Clarify comment (#7918) (overlookmotel) - 41a1456 transformer/class-properties: Correct doc comments (#7966) (overlookmotel) - 18441af transformer/class-properties: Remove oudated todo for assignment expression (#7955) (Dunqing) - 1317c00 transformer/class-properties: Clarify doc comments (#7914) (overlookmotel) - 9989b58 transformer/class-properties: Re-order file list in doc comment (#7911) (overlookmotel) - 7390048 transformer/class-properties: Reformat doc comment (#7909) (overlookmotel) ### Refactor - beb982a ast: Use exhaustive match for `Argument` to `ArrayExpressionElement` conversion (#7848) (overlookmotel) - 3858221 global: Sort imports (#7883) (overlookmotel) - 1314c97 minifier: Expose dce as an API instead of an option (#7957) (Boshen) - 6551dfe semantic: Pass `&str` instead of `Cow` (#7972) (overlookmotel) - b8d2bd2 semantic: Move determining references flags for export specifier to `visit_export_named_declaration` (#7924) (Dunqing) - 98d7946 semantic: Import flags and ID types from `oxc_syntax` (#7887) (overlookmotel) - 1cf8f8f semantic: `SymbolTable::set_name` return old name (#7869) (overlookmotel) - 5d42df8 semantic: Use `Expression::is_super` (#7851) (overlookmotel) - 8cf9766 semantic, syntax, wasm: Remove `#![allow(non_snake_case)]` (#7863) (overlookmotel) - d59bbae transformer: Remove unneeded lint `#[allow]` (#7971) (overlookmotel) - 2c94236 transformer: Improve encapsulation of transforms (#7888) (overlookmotel) - 34091b2 transformer: Use `Expression::is_super` (#7852) (overlookmotel) - d4d7bc0 transformer/async-to-generator: Avoid allocating unnecessary `Atom`s (#7975) (overlookmotel) - 2e5ffd3 transformer/class-properties: Store `temp_var_is_created` on `ClassBindings` (#7981) (overlookmotel) - 27cc6da transformer/class-properties: Store `is_declaration` only on `ClassDetails` (#7980) (overlookmotel) - ee282f8 transformer/class-properties: Remove `move_expression`s (#7979) (overlookmotel) - 94b376a transformer/class-properties: Simplify logic for when to create temp binding (#7977) (overlookmotel) - ff9d1b3 transformer/class-properties: Comments about shorter output (#7976) (overlookmotel) - 6fc40f0 transformer/class-properties: Pass `BoundIdentifier`s by reference (#7968) (overlookmotel) - 69eeeea transformer/class-properties: Methods take `&self` where possible (#7967) (overlookmotel) - 98340bb transformer/class-properties: Use stack of `ClassDetails` (#7947) (overlookmotel) - 088dd48 transformer/class-properties: Shorten code (#7913) (overlookmotel) - 544ffbf transformer/class-properties: Split up code into multiple files (#7912) (overlookmotel) - dcaf674 transformer/class-properties: Rename file (#7910) (overlookmotel) - 6243980 transformer/class-properties: Instance prop inits visitor use `Visit` (#7867) (overlookmotel) - eb47d43 transformer/class-properties: Re-use existing `Vec` (#7854) (overlookmotel) - 1380b7b transformer/class-properties: Reduce visibility of method (#7858) (overlookmotel) - 0f5e078 transformer/class-properties: Rename `*_owner` to `owned_*` (#7855) (Dunqing) - 4ea90d4 transformer/react-refresh: Calculate signature key once (#7970) (Dunqing) - 15b9bff transformer/typescript: Reuse `Atom` (#7969) (overlookmotel) ### Styling - fb897f6 data_structures: Add line break (#7882) (overlookmotel) - 7fb9d47 rust: `cargo +nightly fmt` (#7877) (Boshen) ### Testing - 523d48c transformer: Move named test to exports folder (#7922) (Dunqing) - e766051 transformer: Skip test which uses filesystem under miri (#7874) (overlookmotel) - f39e65e transformer: Prevent lint error when running miri (#7873) (overlookmotel) Co-authored-by: Dunqing <29533304+Dunqing@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For this case, we set
current_reference_flagstoReferenceFlags::TypeforTSInterfaceHeritage, but never unset it, which causes resolvingfowardRefidentifier reusecurrent_reference_flagsofTSInterfaceHeritage.In this PR, reset the
current_reference_flagswhen resolved, so that we don't need to reset it in individual visit functions. This is a reasonable change because thecurrent_reference_flagsonly applies to the next encountered identifier.