fix(linter): turn oxc/no-redundant-constructor-init into typescript/no-unnecessary-parameter-property-assignment #9618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
CodSpeed Performance ReportMerging #9618 will not alter performanceComparing Summary
|
…o-unnecessary-parameter-property-assignment (oxc-project#9599)
ulrichstark
force-pushed
the
rename-no-redundant-constructor-init-lint-rule
branch
from
f7662b1 to
fcd71e7
Compare
ulrichstark
changed the title
ulrichstark
changed the title
Boshen
reviewed
Mar 11, 2025
crates/oxc_linter/src/rules/typescript/no_unnecessary_parameter_property_assignment.rs
Show resolved
Hide resolved
Member
|
Ok, let's do this in 2 PRs. |
Boshen
added a commit
that referenced
this pull request
Mar 12, 2025
## [0.15.15] - 2025-03-12 ### Features - 2ddad59 linter: Add unicorn/require-post-message-target-origin rule (#9684) (yefan) - 474a57b linter: A new multi-file analysis runtime (#9383) (branchseer) ### Bug Fixes - 6c0978b linter: No-single-promise-in-promise-methods: do not fix Promise.all when chained (#9697) (camchenry) - ab594f1 linter: Turn oxc/no-redundant-constructor-init into typescript/no-unnecessary-parameter-property-assignment (#9618) (Uli) - 91c009a linter: Add missing fail cases in `eslint-no-array-constructor` (#9659) (therewillbecode) - 2810e5b linter: Add missing fail cases in eslint/no-self-compare (#9693) (therewillbecode) ### Refactor - b9ab60b linter: Remove if let nesting from `bad-min-max-function` (#9722) (therewillbecode) - 90b0227 linter: Remove if let nesting from `eslint-operator-assignment` (#9721) (therewillbecode) - 5ef578e linter: Improve `jest/no-alias-methods` (#9694) (therewillbecode) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Boshen
pushed a commit
that referenced
this pull request
Mar 17, 2025
…meter_property_assignment (#9720) Followup to #9618. PRs for oxc/no-redundant-constructor-init: #9299 #9364 typescript-eslint rule: [Docs](https://typescript-eslint.io/rules/no-unnecessary-parameter-property-assignment) [Source](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/src/rules/no-unnecessary-parameter-property-assignment.ts) [Tests](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/tests/rules/no-unnecessary-parameter-property-assignment.test.ts) Changes of this PR: - Imported tests from typescript-eslint - Added one more passing test to the end - Fixed all new test cases - Changed rule category back to correctness This is my first major change to OXC. If there's anything wrong or not the OXC-way, I will happily improve on that.
shulaoda
pushed a commit
that referenced
this pull request
Mar 24, 2025
…eter_property_assignment` and fix false positive (#9973) Hey, I just added a suggested fix to the lint rule as continuation of my work in #9720 and #9618. The original typescript-eslint rule isn't capable of fixing its reported issue, but the fix should be pretty safe. I decided to configure it as `suggestion` and not as 100% safe `fix`. Also found one false positive while implementing the fix suggestion, fixed it and added a corresponding passing test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9599
I switched the category to nursery because in a followup PR I will import all tests from typescript-eslint and attempt to fix all of them. This separation into two PRs makes the changes easier to review and preserves the history and original author of the lint rule.