Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(miri): run Miri on oxc_data_structures crate with all features enabled #9882

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Mar 19, 2025

#9849 put all parts of oxc_data_structures behind features. I neglected to make Miri run on the crate with all those features activated, so it was skipping all the tests. Fix that.

Copy link
Contributor Author

overlookmotel commented Mar 19, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review March 19, 2025 04:15
@Boshen Boshen merged commit 74e3567 into main Mar 19, 2025
7 checks passed
@Boshen Boshen deleted the 03-19-ci_miri_run_miri_on_oxc_data_structures_crate_with_all_features_enabled branch March 19, 2025 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants