Skip to content

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Sep 8, 2025

This adds a test to prevent regressions.

While e2e/fixtures/with-unmatched-files/src/index.ts​ is in the project, e2e/fixtures/with-unmatched-files/test.ts​ is not. We are expecting both to have the same diagnostics printed for both.

@camc314 camc314 marked this pull request as ready for review September 8, 2025 06:50
Copy link
Contributor Author

camc314 commented Sep 8, 2025


How to use the Graphite Merge Queue

Add the label 0-merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a regression test to verify that TSGoLint correctly handles files both inside and outside of a TypeScript project configuration. The test ensures that linting behavior is consistent between files included in tsconfig.json and those that are not.

  • Adds a new E2E test case that validates linting of files outside project configuration
  • Creates test fixtures with identical TypeScript code in both included and excluded locations
  • Verifies that both files produce the same diagnostic output for the no-unsafe-argument rule

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
e2e/snapshot.test.ts Adds new test case for linting files outside project configuration
e2e/fixtures/with-unmatched-files/tsconfig.json Creates TypeScript project config that only includes src/**/*
e2e/fixtures/with-unmatched-files/test.ts Test file outside project configuration with unsafe argument usage
e2e/fixtures/with-unmatched-files/src/index.ts Test file inside project configuration with identical unsafe argument usage
e2e/snapshots/snapshot.test.ts.snap Expected snapshot output showing diagnostics for both files

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@graphite-app
Copy link

graphite-app bot commented Sep 8, 2025

Merge activity

This adds a test to prevent regressions.

While `e2e/fixtures/with-unmatched-files/src/index.ts`​ is in the project, `e2e/fixtures/with-unmatched-files/test.ts`​ is not. We are expecting both to have the same diagnostics printed for both.
@graphite-app graphite-app bot force-pushed the c/09-08-test_add_test_for_linting_files_outside_a_project branch from b59efbc to adde814 Compare September 8, 2025 07:02
@graphite-app graphite-app bot merged commit adde814 into main Sep 8, 2025
9 checks passed
@graphite-app graphite-app bot deleted the c/09-08-test_add_test_for_linting_files_outside_a_project branch September 8, 2025 07:14
@graphite-app graphite-app bot removed the 0-merge label Sep 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants