-
-
Notifications
You must be signed in to change notification settings - Fork 29
test: add test for linting files outside a project #215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add test for linting files outside a project #215
Conversation
How to use the Graphite Merge QueueAdd the label 0-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a regression test to verify that TSGoLint correctly handles files both inside and outside of a TypeScript project configuration. The test ensures that linting behavior is consistent between files included in tsconfig.json and those that are not.
- Adds a new E2E test case that validates linting of files outside project configuration
- Creates test fixtures with identical TypeScript code in both included and excluded locations
- Verifies that both files produce the same diagnostic output for the
no-unsafe-argumentrule
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| e2e/snapshot.test.ts | Adds new test case for linting files outside project configuration |
| e2e/fixtures/with-unmatched-files/tsconfig.json | Creates TypeScript project config that only includes src/**/* |
| e2e/fixtures/with-unmatched-files/test.ts | Test file outside project configuration with unsafe argument usage |
| e2e/fixtures/with-unmatched-files/src/index.ts | Test file inside project configuration with identical unsafe argument usage |
| e2e/snapshots/snapshot.test.ts.snap | Expected snapshot output showing diagnostics for both files |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Merge activity
|
This adds a test to prevent regressions. While `e2e/fixtures/with-unmatched-files/src/index.ts` is in the project, `e2e/fixtures/with-unmatched-files/test.ts` is not. We are expecting both to have the same diagnostics printed for both.
b59efbc to
adde814
Compare

This adds a test to prevent regressions.
While
e2e/fixtures/with-unmatched-files/src/index.ts is in the project,e2e/fixtures/with-unmatched-files/test.ts is not. We are expecting both to have the same diagnostics printed for both.