Skip to content

Conversation

@liam923
Copy link
Contributor

@liam923 liam923 commented Jan 31, 2025

This change is backported from an upstream PR: ocaml/merlin#1888. The rest of the changes in that PR are already in merlin-jst.

@liam923 liam923 requested a review from goldfirere January 31, 2025 18:56
Copy link
Contributor

@goldfirere goldfirere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really understand. This just adds a new module, presumably not used. How does that have an effect?

I have Approved so as not to be a blocker, but I'm a bit confused.

@liam923
Copy link
Contributor Author

liam923 commented Jan 31, 2025

@goldfirere This is a module that previously lived in ocaml-lsp, but got moved into Merlin upstream. This will have no effect on Merlin, but allows us to reduce the lsp's diff with upstream.

@liam923 liam923 merged commit 942d289 into main Jan 31, 2025
1 of 2 checks passed
@liam923 liam923 deleted the rename-holes branch January 31, 2025 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants