use weak_ptr instead of bare pointer to prevent use after free

oxen-io · Jun 25, 2021 · abd6e4c · abd6e4c
1 parent aa48a1d
commit abd6e4c
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/llarp/service/outbound_context.cpp b/llarp/service/outbound_context.cpp
@@ -195,8 +195,16 @@ namespace llarp
     OutboundContext::HandlePathBuilt(path::Path_ptr p)
     {
       path::Builder::HandlePathBuilt(p);
-      p->SetDataHandler(util::memFn(&OutboundContext::HandleHiddenServiceFrame, this));
-      p->SetDropHandler(util::memFn(&OutboundContext::HandleDataDrop, this));
+      p->SetDataHandler([self = weak_from_this()](auto path, auto frame) {
+        if (auto ptr = self.lock())
+          return ptr->HandleHiddenServiceFrame(path, frame);
+        return false;
+      });
+      p->SetDropHandler([self = weak_from_this()](auto path, auto id, auto seqno) {
+        if (auto ptr = self.lock())
+          return ptr->HandleDataDrop(path, id, seqno);
+        return false;
+      });
       if (markedBad)
       {
         // ignore new path if we are marked dead