add instructions to build a quick docker image for dev and production #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majestrate
reviewed
Mar 21, 2022
jagerman
requested changes
Mar 22, 2022
There was a problem hiding this comment.
Some minor changes included as comments here.
I also think we should move the /docker bits into /contrib/docker which might make people realize that this isn't for production use.
(There are some community members interested in creating a production docker image for pysogs, though that will look a little different — most likely by using the python3-sogs package to install the production version rather than reusing a current dev branch checkout.)
Bilb
force-pushed
the
docker
branch
3 times, most recently
from
bd59f91 to
2d33409
Compare
jagerman
reviewed
Apr 13, 2022
Bilb
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's left to be done is