make readiness probe optional

[nicolasochem]

For Teztnets, it's useful to disable this probe: when I start a new
testnet, sometimes I am waiting for other participants to join for the
chain to kick off.

When recreating dailynet or mondaynet, I need to wait for other peers to
connect to me to download the most recent blocks: with a probe, that's
not possible.

Must be explicitly set to false, otherwise by default the probe will be
present. It can only be set at node type level. Since it's processed by
helm and not config-generator, I didn't see a way to make it
configurable at global or instance level.

I will need this to migrate teztnets to the new aws org without disruption.

[harryttd]

It is good to add this option. Just a few questions:

when I start a new
testnet, sometimes I am waiting for other participants to join for the
chain to kick off.

If it doesn't have blocks and so is on 0, doesn't it return success?

When recreating dailynet or mondaynet, I need to wait for other peers to
connect to me to download the most recent blocks: with a probe, that's
not possible.

Does this mean that the chain already exists and has blocks? So basically blocks stopped being produced and therefore the chain gets older and probe returns false?

Since it's processed by helm and not config-generator, I didn't see a way to make it
configurable at global or instance level.

Can set option in those places and then mount tezos-config configMap? Then probe looks at NODE_GLOBALS and it's own node options. Can return success msg saying why skipping validation.

[nicolasochem]

If it doesn't have blocks and so is on 0, doesn't it return success?

Yes, but sometimes there are hiccups, for example 10 blocks go through and then nothing.

Also on tenderbake, when there is no quorum, the node keeps emitting blocks at the same level but different "rounds", but only when it has rights to do so. In mondaynet for example, this results in the liveness probe "blinking". Bottom, line, I just want to remove it for the teztnets platform.

When recreating dailynet or mondaynet, I need to wait for other peers to
connect to me to download the most recent blocks: with a probe, that's
not possible.

Does this mean that the chain already exists and has blocks? So basically blocks stopped being produced and therefore the chain gets older and probe returns false?

Yes, correct. And when the probe returns false, other nodes won't be able to connect to it. If other nodes know of more recent blocks, they won't be able to upload them to our node.

Since it's processed by helm and not config-generator, I didn't see a way to make it
configurable at global or instance level.

Can set option in those places and then mount tezos-config configMap? Then probe looks at NODE_GLOBALS and it's own node options. Can return success msg saying why skipping validation.

True. It's a different approach. In my current approach, I simply remove the sidecar and the readiness configuration.

[harryttd]

👍 👍

[elric1]

This is in one of my pull requests as well. I'll take it out, if we approve this one first.