update default octez to v12 #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change version in test value files as well. Also fix a few outdated tests.
harryttd
reviewed
Mar 24, 2022
| @@ -146,7 +151,7 @@ spec: | |||
| readinessProbe: | |||
| httpGet: | |||
| path: /is_synced | |||
| port: 31732 | |||
| port: 31732 | |||
There was a problem hiding this comment.
theres some random white space being added in a bunch of places 🤷
There was a problem hiding this comment.
There is a helper script to re-generate the expected helm template. I ran it to update to v12 everywhere in the tests, then this happened. I believe whitespace was already there. Perhaps a tab vs space situation. This should be addressed separately.
There was a problem hiding this comment.
I think that what's going on here is that a prior commit didn't update the expect files. Once we enforce this on every pull request we won't see this.
elric1
approved these changes
Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change version in test value files as well. Also fix a few outdated tests.