make hard-coded identity work when snapshot is being imported #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snapshot import wipes the data dir. But we may write an identity.json file in it. This PR ensures that we are not deleting it after writing it! We also write it at every boot (because what if the user wants to change it?) We add the node id in the debug log for config-generator.
|
I verified it was working on oxheadinfra mainnet-dev by temporarily pointing a submod to this branch. |
orcutt989
approved these changes
Apr 8, 2022
harryttd
requested changes
Apr 8, 2022
harryttd
approved these changes
Apr 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Snapshot import wipes the data dir. But we may write an identity.json
file in it. This PR ensures that we are not deleting it after writing
it!
We also write it at every boot (because what if the user wants to change
it?)
We add the node id in the debug log for config-generator.