Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snapshot bugfix #411

Merged
merged 13 commits into from
Apr 14, 2022
Merged

Snapshot bugfix #411

merged 13 commits into from
Apr 14, 2022

Conversation

orcutt989
Copy link
Contributor

@orcutt989 orcutt989 commented Apr 13, 2022 •
edited
Loading

Currently deployed and working.

This fixes some bugs found with the snapshot-engine.

  1. Fix wrong image name in values.yaml on dockerhub
  2. Pass in markdown for chain site as snapshotMarkdownTemplateUrl value.
  3. Fix Service account variable is hardcoded in some places #414
  4. Fix Snapshot Engine: volumeSnapshotClassName is hardcoded #417

nicolasochem
nicolasochem previously approved these changes Apr 13, 2022
View reviewed changes
@orcutt989 orcutt989 marked this pull request as draft April 14, 2022 17:18
@orcutt989 orcutt989 requested review from nicolasochem and removed request for nicolasochem and harryttd April 14, 2022 17:18
@orcutt989 orcutt989 marked this pull request as ready for review April 14, 2022 17:20
@orcutt989 orcutt989 marked this pull request as draft April 14, 2022 17:20
@orcutt989 orcutt989 marked this pull request as ready for review April 14, 2022 19:31
nicolasochem
nicolasochem approved these changes Apr 14, 2022
View reviewed changes
Copy link
Collaborator

@nicolasochem nicolasochem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't try, but it looks like everything is here. Thanks

harryttd
harryttd requested changes Apr 14, 2022
View reviewed changes
snapshotEngine/snapshot-maker.sh Outdated Show resolved Hide resolved
charts/snapshotEngine/templates/snapshot-scheduler.yaml Outdated Show resolved Hide resolved
snapshotEngine/mainJob.yaml Outdated Show resolved Hide resolved
snapshotEngine/snapshotMakerJob.yaml Show resolved Hide resolved
harryttd
harryttd approved these changes Apr 14, 2022
View reviewed changes
Copy link
Collaborator

@harryttd harryttd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you. please squash and delete branch

@orcutt989 orcutt989 merged commit 8901019 into master Apr 14, 2022
@orcutt989 orcutt989 deleted the snapshot-bugfix branch April 14, 2022 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolasochem nicolasochem nicolasochem approved these changes

@harryttd harryttd harryttd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Snapshot Engine: volumeSnapshotClassName is hardcoded Service account variable is hardcoded in some places
3 participants
@orcutt989 @nicolasochem @harryttd