Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add explanatory comments to snapshotEngine's values.yaml #415

Merged
merged 4 commits into from
Apr 14, 2022

Conversation

nicolasochem
Copy link
Collaborator

also replace v12.2 with v12-release to follow tezos-k8s convention

also replace `v12.2` with `v12-release` to follow tezos-k8s convention
Copy link
Collaborator

@harryttd harryttd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the great comments

charts/snapshotEngine/values.yaml Show resolved Hide resolved
charts/snapshotEngine/values.yaml Outdated Show resolved Hide resolved
charts/snapshotEngine/values.yaml Outdated Show resolved Hide resolved
charts/snapshotEngine/values.yaml Outdated Show resolved Hide resolved
nicolasochem and others added 3 commits April 13, 2022 16:16
Co-authored-by: Aryeh Harris <harryttd@users.noreply.github.com>
Co-authored-by: Aryeh Harris <harryttd@users.noreply.github.com>
Copy link
Contributor

@orcutt989 orcutt989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@nicolasochem nicolasochem merged commit 24a0508 into master Apr 14, 2022
@harryttd harryttd deleted the snapshot_engine_values_comments branch May 24, 2022 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants