preserve ordering of bootstrap parameters in mkchain #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bootstrap parameters for mkchain are saved in a file, but when we assemle a values file, we store it alphabetically. I like to have my parameters sorted always the same way. We replace PyYAML with oyaml, which preserves ordering.
|
This is a good idea :) Something i've wanted We could keep the official lib and just add in the |
Ooh thanks. How did I miss this? |
|
@harryttd your suggestion has been applied, please review |
harryttd
approved these changes
Jul 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bootstrap parameters for mkchain are saved in a file, but PyYAML reorders them so they appear alphabetically in the values.yaml file outputted by mkchain. I like to have my chain bootstrap parameters sorted always the same way.
We pass a parameter to the pyyaml dumper to tell it to preserve ordering.