TRD mainnet adaptations #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasochem
force-pushed
the
trd_mainnet
branch
from
49b48e0
to
c397592
Compare
nicolasochem
force-pushed
the
trd_mainnet
branch
from
c397592
to
5fba7fb
Compare
harryttd
requested changes
Mar 24, 2023
Comment on lines
+81
to
+83
| - name: report-uploader | ||
| image: {{ .Values.tezos_k8s_images.snapshotEngine }} | ||
| volumeMounts: |
There was a problem hiding this comment.
It seems this is always run even if none of the aws and bucket vals are set
When you pass custom values.yaml with TRD config, it gets merged with this dummy default config that was in the yaml. It's best to put nothing and let the user set the entire config in custom values.ayml |
|
ah understood. How about leaving the properties as actual values but leaving them empty or with empty strings for example. Especially for properties that must be set to indicate to the user they must set them |
harryttd
reviewed
Mar 24, 2023
harryttd
approved these changes
Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I deployed TRD against a mainnet baker with tezos-k8s and found a few missing parameters from the original work. Adding them.
Also, I am commenting out by default the TRD params in values.yaml, otherwise they get deep-merged by helm, which yields odd results.
I am also adding the option to upload the resulting data from trd to a bucket. Since TRD runs in a cronjob, it's hard to shell into it to look at the files. Uploading the entire PVC to a bucket is a nice substitute.