Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

one process per baker #517

Merged
merged 3 commits into from
Dec 29, 2022
Merged

one process per baker #517

merged 3 commits into from
Dec 29, 2022

Commits on Dec 17, 2022

  1. one process per baker

    When baking for several addresses, today we instantiate only one baker
    process. This is unsupported and bad, because it does things
    sequentially. The supported way to bake for several addresses is to run
    one baking process per address. This PR changes tezos-k8s to do that.
    
    This is a second, less intrusive attempt after feedback from Aryeh.
    
    * helm computes the maximum number of baking processes that any pod in
      the statefulset would need
    * instantiates the max number of bakers for each pod (no choice here..)
    * the baker entrypoint figures which baker it must bake for thanks to a
      new BAKER_INDEX env var. If it must idle, it enters an infinite
      sleeping loop.
    
    This works when using `bake_using_accounts`. I verified that I did not
    break `bake_using_account`.
    
    I verified by:
    * creating a private chain with 3 bakers using mkchain
    * assigning two bakers to the first node and one baker to the second
    
    I also ran mkchain with no parameters to ensure it still works.
    
    Various cleanups:
    
    * remove a octez v13 specific catch (must pass toggle even when vote
      file absent) in the baker entrypoint
    * remove the DAEMON env var in baker (was used to disambiguate between
      baker and endorser)
    
    Random comment:
    
    I don't think it's great that the logic to pick the baking accounts is
    written in config-generator.sh instead of py, but I'm not changing this
    here.
    nicolasochem committed Dec 17, 2022
    Configuration menu
    Copy the full SHA
    5944c3b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5b65c01 View commit details
    Browse the repository at this point in the history

Commits on Dec 29, 2022

  1. Configuration menu
    Copy the full SHA
    8258389 View commit details
    Browse the repository at this point in the history