Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more k8s template configuration options for BCD #560

Merged
merged 4 commits into from
Mar 9, 2023
Merged

Add more k8s template configuration options for BCD #560

merged 4 commits into from
Mar 9, 2023

Conversation

harryttd
Copy link
Collaborator

@harryttd harryttd commented Mar 8, 2023

No description provided.

@harryttd harryttd self-assigned this Mar 8, 2023
@puppetninja
Copy link
Collaborator

I think it would be good to add some comments to values.yaml for this

@harryttd harryttd changed the title Ability to configure nodeSelector, affinity, and tolerations for BCD Add more k8s template configuration options for BCD Mar 9, 2023
@harryttd
Copy link
Collaborator Author

harryttd commented Mar 9, 2023

I ended up specifying the added fields explicitly in values.yaml

nicolasochem
nicolasochem approved these changes Mar 9, 2023
View reviewed changes
Copy link
Collaborator

@nicolasochem nicolasochem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I am assuming it works properly. For values.yaml I think it's pretty self explanatory because you can find the same fields in many charts, including the empty chart created by helm new.

@harryttd harryttd merged commit f91baa3 into master Mar 9, 2023
@harryttd harryttd deleted the bcd-node-selector branch March 9, 2023 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolasochem nicolasochem nicolasochem approved these changes

Assignees

@harryttd harryttd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@harryttd @puppetninja @nicolasochem