Add local_storage_size option in values #594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some cloud provider have minimum pvc size requirement, like Aliyun, this option would also tezos-k8s to be deployed under such scenarios.
harryttd
requested changes
Jul 11, 2023
charts/tezos/templates/nodes.yaml
Outdated
Comment on lines
89
to
92
| storage: {{ default "1Gi" $.node_vals.local_storage_size }} | ||
| {{- else }} | ||
| storage: {{ default "15Gi" $.node_vals.storage_size }} | ||
| {{- end }} |
There was a problem hiding this comment.
I don't think we need to introduce a brand new field here. You can use logic to determine the default size and just use storage_size.
There was a problem hiding this comment.
I think it would be confusing, to configure pvcs for different purposes with same helm value, they even have different pvc names.
There was a problem hiding this comment.
i see what you are saying. Maybe we rename local_storage_size then because that sounds like the size of the local temp memory of the machine which isn't persistent and isn't what is being configured. Maybe local_storage_pv_size?
|
I rebased it instead of squashing my commits, sorry for that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some cloud provider have minimum pvc size requirement, like Aliyun, this option would also tezos-k8s to be deployed under such scenarios.