Creating a new firewall rule with the same name overwrites original

[benjaminleonard]

Tested on both the mock API and colo.

A side effect that we work with the entire firewall rules object rather than individual rules in the API. We should prevent the user from creating a new rule with a duplicate name.

This does strike me as another downside to the current API, requiring extra logic on the client like this.

[david-crespo]

As my 2 year old TODO comment says, I think we should error or at least require confirmation when you try to create a rule with the same name as an existing one. If we're going to block it entirely, it would be nice to error immediately on blur so the user doesn't have to fill out the whole rule before they find out they need to switch to the edit form. Another important point is that we also need to warn/block/confirm on the edit form if the user edits rule A and changes the name to that of existing rule B.

console/app/forms/firewall-rules-create.tsx

Lines 558 to 562 in a06d852

	// TODO: this silently overwrites existing rules with the current name.
	// we should probably at least warn and confirm, if not reject as invalid
	const otherRules = existingRules
	.filter((r) => r.name !== values.name)
	.map(firewallRuleGetToPut)