Instance quick actions need feedback and confirmation (or remove them)

[david-crespo]

On instance detail, we put instance actions like stop/start/delete etc in the quick actions menu, but when I tried these I noticed several problems:

• No toast feedback or query invalidate on success
• Seemed not to work sometimes
• No confirmation on destructive actions

I would guess roughly no one is using these anyway, so it could well be the most expedient fix is to remove them from the menu, and then we can put them back in later if we have time.

console/app/pages/project/instances/instance/InstancePage.tsx

Lines 119 to 142 in e7d7d95

	const actions = useMemo(
	() => [
	{
	label: 'Copy ID',
	onActivate() {
	window.navigator.clipboard.writeText(instance.id || '')
	},
	},
	...makeActions(instance),
	],
	[instance, makeActions]
	)
	const quickActions = useMemo(
	() =>
	actions
	// in the quick menu we do not show disabled actions
	.filter((a) => !a.disabled)
	// append "instance" to labels
	// TODO: if these were in an "Instance actions" subsection they might not
	// need the suffix for clarity
	.map((a) => ({ onSelect: a.onActivate, value: a.label })),
	[actions]
	)
	useQuickActions(quickActions)

[charliepark]

A few notes on this

• I find the actions on the per-instance page to be kind of useful, rather than using the actions on the index / list of instances page. It's quite possible my typical usage is different from a normal usage pattern, but I wonder if removing the actions is best.
• I think I'm seeing confirmation on the dangerous actions; maybe I'm looking at the wrong thing?
• I think some of our e2e tests use the instance page actions as part of their flow, so we might need to re-think how we want to handle those.

[david-crespo]

You are looking at the wrong thing: what I call "quick actions" is the cmd+k modal UI.

[charliepark]

I wondered if that might be the case. 🫠