Tests involving react table are slow and sometimes flake

[david-crespo]

I went down the rabbit hole on this and will add more info here later, but I think we are mostly not doing anything wrong, and basically jsdom is very slow sometimes. Can't repro the issue in browser.

[david-crespo]

Justin and I did some profiling and figured out it seemed to come down to querying the DOM by role being very slow. Turns out there is a dom-testing-library PR in progress that claims to speed it up by 2 orders of magnitude, but it hasn't been touched in two weeks. It does seem good, though, and it's nearly approved, so maybe we can wait until this drops to worry about it.

testing-library/dom-testing-library#1086

[david-crespo]

This is more like our real problem: when getByRole takes too long, it takes longer than the waitFor loop interval and so the queue just fills up with a ton of getByRoles.

testing-library/dom-testing-library#820

[david-crespo]

The answer is: don't use findByRole until they fix it. getByRole is ok but be aware it can add 50-100ms to a test.