Update buttons to be more accessible #1292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
david-crespo
reviewed
Nov 8, 2022
david-crespo
reviewed
Nov 8, 2022
| addVariant('children', '& > *') | ||
| addVariant('between', '& > * + *') | ||
| addVariant('selected', '.is-selected &') | ||
| addVariant('disabled', '&.visually-disabled, &:disabled') |
david-crespo
reviewed
Nov 8, 2022
| e.stopPropagation() | ||
| e.preventDefault() | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
Love this. Hope we don't find this breaks some other click behavior in the container.
Co-authored-by: David Crespo <david-crespo@users.noreply.github.com>
This was referenced Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
disabledbuttons have a bit of an accessibility problem in that they can't be tabbed to. While they technically still show up in the accessibility tree, they're often effectively invisible when many screen readers rely on tabbing behavior to announce UI elements.This PR alters the
button'sdisabledprop to add avisually-disabledclass instead of thedisabledattribute. When thedisabledprop is present it turns theonClickandonMouseDownprops to no-ops. To preserve the styling I've overridden the defaultdisabledtailwind to support both thedisabledpseudo selector and thevisually-disabledclass.Follow-ups
Once #1288 is merged I'm going to follow up with an update to make it easier to attach tooltips to elements and add a
disabledReasonprop to the button to be able to invoke a tooltip to say why a button is disabled.