Convert API calls to the v1 endpoints #1366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
david-crespo
force-pushed
the
lets-go-v1
branch
from
b43e1ac to
64681d0
Compare
david-crespo
force-pushed
the
lets-go-v1
branch
from
64681d0 to
8c4caa1
Compare
david-crespo
force-pushed
the
lets-go-v1
branch
from
8c4caa1 to
4cde77b
Compare
david-crespo
commented
Feb 18, 2023
| instanceNetworkInterfaceDelete(params) { | ||
| const nic = lookupNetworkInterface(params.path) | ||
| instanceNetworkInterfaceDeleteV1({ path, query }) { | ||
| const nic = lookup.networkInterface({ ...path, ...query }) |
Collaborator
Author
There was a problem hiding this comment.
The changes in this file are trivial, so that's good. The calling code badly needs some helpers to clean it up.
just-be-dev
reviewed
Feb 21, 2023
| }: CreateSideModalFormProps) { | ||
| const queryClient = useApiQueryClient() | ||
| const pathParams = useRequiredParams('orgName', 'projectName') | ||
| const projectSelector = useProjectSelector() |
Contributor
There was a problem hiding this comment.
I do like this API overall.
david-crespo
changed the title
david-crespo
force-pushed
the
lets-go-v1
branch
from
a371aeb to
18e0083
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did all the ones that are in the API and currently being used in the console.
Things to note
Updating list as I go:
setQueryData, we need to make sure we're using the exact same parameters in all the relevant spots. We can'tsetQueryDataby ID in one place and then do the lookup by name.Followup work
projectNametoproject, etc. There's no reason they need to be different from the API ones, I was just trying to make the diff less ridiculous