Skip to content

Change close button on modal to absolute positioned have correct tab order #1715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
just-be-dev merged 2 commits into from
Aug 8, 2023
Merged

Change close button on modal to absolute positioned have correct tab order #1715

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b3f7c8c
Change close button to absolute positioned have correct tab order
just-be-dev Aug 8, 2023
2088cf0
Tweak alignment
benjaminleonard Aug 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions libs/ui/lib/modal/Modal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ export function Modal({ children, onDismiss, title, isOpen }: ModalProps) {
>
<Dialog.Portal>
<div
className="DialogOverlay pointer-events-auto"
className="DialogOverlay pointer-events-auto relative"
onClick={onDismiss}
aria-hidden
/>
Expand All @@ -75,6 +75,12 @@ export function Modal({ children, onDismiss, title, isOpen }: ModalProps) {
</Dialog.Title>
)}
{children}
<Dialog.Close
Copy link
Contributor

@benjaminleonard benjaminleonard Aug 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to add a comment for context like the side modal — in case this component is recreated and we hit the same issue again.

className="absolute right-2 top-3 flex rounded p-2 hover:bg-hover"
aria-label="Close"
>
<Close12Icon className="text-secondary" />
</Dialog.Close>
</AnimatedDialogContent>
</Dialog.Portal>
</Dialog.Root>
Expand All @@ -99,9 +105,6 @@ const ModalTitle = forwardRef<HTMLDivElement, ModalTitleProps>(({ children, id }
<h2 className="text-sans-semi-lg" id={id}>
{children}
</h2>
<Dialog.Close className="-m-2 flex rounded p-2 hover:bg-hover" aria-label="Close">
<Close12Icon className="text-secondary" />
</Dialog.Close>
</div>
))

Expand Down