Add snapshot action to instance disks list #1774
Merged
+63
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
david-crespo
commented
Oct 5, 2023
| await page.getByRole('link', { name: 'Snapshots' }).click() | ||
| const table = page.getByRole('table') | ||
| await expectRowVisible(table, { | ||
| name: expect.stringMatching(/^disk-2-/), |
Collaborator
Author
There was a problem hiding this comment.
Had to add this to be able to match on a partial cell content. It works for free because we're already using objectContaining in expectRowVisible.
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Oct 14, 2023
oxidecomputer/console@0cc1e03...9940fd0 * [9940fd0d](oxidecomputer/console@9940fd0d) oxidecomputer/console#1790 * [d07ca142](oxidecomputer/console@d07ca142) oxidecomputer/console#1784 * [0a32ccf8](oxidecomputer/console@0a32ccf8) oxidecomputer/console#1787 * [e74d5aec](oxidecomputer/console@e74d5aec) oxidecomputer/console#1772 * [a68c7c86](oxidecomputer/console@a68c7c86) oxidecomputer/console#1779 * [b2b3a748](oxidecomputer/console@b2b3a748) oxidecomputer/console#1774 * [0f015505](oxidecomputer/console@0f015505) bump playwright for UI mode improvements * [1ccff371](oxidecomputer/console@1ccff371) oxidecomputer/console#1582
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Oct 14, 2023
oxidecomputer/console@0cc1e03...9940fd0 * [9940fd0d](oxidecomputer/console@9940fd0d) oxidecomputer/console#1790 * [d07ca142](oxidecomputer/console@d07ca142) oxidecomputer/console#1784 * [0a32ccf8](oxidecomputer/console@0a32ccf8) oxidecomputer/console#1787 * [e74d5aec](oxidecomputer/console@e74d5aec) oxidecomputer/console#1772 * [a68c7c86](oxidecomputer/console@a68c7c86) oxidecomputer/console#1779 * [b2b3a748](oxidecomputer/console@b2b3a748) oxidecomputer/console#1774 * [0f015505](oxidecomputer/console@0f015505) bump playwright for UI mode improvements * [1ccff371](oxidecomputer/console@1ccff371) oxidecomputer/console#1582
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1771
Confirmation toast continues to be unimpressive. That will be addressed with #1211.