Skip to content

Fix issue where empty IP on a NIC is submitted as an empty string #1811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
david-crespo merged 3 commits into from
Dec 4, 2023
Merged

Fix issue where empty IP on a NIC is submitted as an empty string #1811

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
965aa4c
Fix issue where empty IP on a NIC is submitted as an empty string
just-be-dev Nov 14, 2023
facb0c8
Merge branch 'main' into fix-1438
david-crespo Dec 2, 2023
0d1f93e
regen client with another oxide.ts fix
david-crespo Dec 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/forms/network-interface-create.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ import { useForm, useProjectSelector } from 'app/hooks'
const defaultValues: InstanceNetworkInterfaceCreate = {
name: '',
description: '',
ip: '',
ip: undefined,
Copy link
Collaborator

@david-crespo david-crespo Nov 14, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this will only work with the initial value, but not if you type something in and then delete it. You might need to do something ugly like add a prop to TextField that tells it the value should be undefined when the string is empty.

Copy link
Contributor Author

@just-be-dev just-be-dev Nov 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, you're right.

subnetName: '',
vpcName: '',
}
Expand Down
31 changes: 16 additions & 15 deletions libs/api/__generated__/msw-handlers.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

38 changes: 23 additions & 15 deletions libs/api/__generated__/validate.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion tools/generate_api_client.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ GEN_DIR="$PWD/libs/api/__generated__"

# this will be less horrific when the package is published? or maybe not
npm run --silent --prefix ../oxide.ts gen-from $OMICRON_SHA $GEN_DIR
npx prettier --write --loglevel error "$GEN_DIR"
npx prettier --write --log-level error "$GEN_DIR"

# hack until we start pulling this from npm. we don't want this file
rm "$GEN_DIR/type-test.ts"
Expand Down