Update how our util functions round numbers#1865
Merged
david-crespo merged 3 commits intomainfrom Dec 17, 2023
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| <div> | ||
| {allocated - provisioned} {unit && <span className="text-tertiary">{unit}</span>} | ||
| {round(allocated - provisioned, 2)} | ||
| {unit && <span className="text-tertiary"> {unit}</span>} |
Collaborator
There was a problem hiding this comment.
ah so we did forget to round! the mistake was assuming the difference of two rounded numbers would remain rounded. JAVASCRIPT
david-crespo
approved these changes
Dec 17, 2023
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Dec 17, 2023
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Dec 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1864