Adds copy button on instance external IP #1885
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses new icon and snazzy animation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
benjaminleonard
changed the title
david-crespo
added a commit
that referenced
this pull request
Jan 17, 2024
* Add VPC and instance external IP to instance page * Use slash as divider * Adds copy button on instance external IP (#1885) * Update copy to clipboard component Uses new icon and snazzy animation * Add copy to clipboard to external IP * `CopyOnTruncate` component * Add description to `CopyOnTruncate` * Revert "Add description to `CopyOnTruncate`" This reverts commit 4bf0bcc. * Revert "`CopyOnTruncate` component" This reverts commit e4a0107. * basic externalIps table. every instance still has the same IP though * make external IPs legit * add file license * fix fallback logic around no IPs * skeleton cell component * Give properties row a fixed height * `EmptyCellContent` component instead of `—` directly * extract ExternalIps component that doesn't know about primary * put https on IP link * remove external IP column from nics table, add asserts to e2e test * put prefetches in Promise.all * sneaky prefetch on VPC name * share primary VPC ID logic --------- Co-authored-by: David Crespo <david.crespo@oxidecomputer.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1775
With updated copy to clipboard component:
