Improve disabled radio state #1897
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminleonard
commented
Jan 22, 2024
libs/api-mocks/msw/handlers.ts
Outdated
| } | ||
| db.instances.push(newInstance) | ||
|
|
||
| await new Promise((resolve) => setTimeout(resolve, 5000)) |
Contributor
Author
There was a problem hiding this comment.
I can remove but helps for testing and is a bit more realistic.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
david-crespo
approved these changes
Jan 22, 2024
Collaborator
david-crespo
left a comment
david-crespo
left a comment
There was a problem hiding this comment.
Looks great. The class is getting ridiculous. Don't tell the Tailwind haters.
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Jan 23, 2024
oxidecomputer/console@644a45b...b9013a3 * [b9013a33](oxidecomputer/console@b9013a33) oxidecomputer/console#1898 * [fb9e9ca5](oxidecomputer/console@fb9e9ca5) oxidecomputer/console#1904 * [9ae29498](oxidecomputer/console@9ae29498) oxidecomputer/console#1897 * [6b894ceb](oxidecomputer/console@6b894ceb) oxidecomputer/console#1901 * [d80d2e7c](oxidecomputer/console@d80d2e7c) oxidecomputer/console#1886 * [2a7da0fa](oxidecomputer/console@2a7da0fa) bump vite for security fix * [700e2700](oxidecomputer/console@700e2700) oxidecomputer/console#1893
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Jan 23, 2024
oxidecomputer/console@644a45b...b9013a3 * [b9013a33](oxidecomputer/console@b9013a33) oxidecomputer/console#1898 * [fb9e9ca5](oxidecomputer/console@fb9e9ca5) oxidecomputer/console#1904 * [9ae29498](oxidecomputer/console@9ae29498) oxidecomputer/console#1897 * [6b894ceb](oxidecomputer/console@6b894ceb) oxidecomputer/console#1901 * [d80d2e7c](oxidecomputer/console@d80d2e7c) oxidecomputer/console#1886 * [2a7da0fa](oxidecomputer/console@2a7da0fa) bump vite for security fix * [700e2700](oxidecomputer/console@700e2700) oxidecomputer/console#1893
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tweaked the disabled radio state to match the other inputs, change cursor, hover no longer changes border colour.
That class is getting pretty complex, but unsure on how we might clean it up. I ended up grouping by state and type.