Skip to content

Remove 'Settings' link from sidebar nav #1901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
charliepark merged 3 commits into from
Jan 22, 2024
Merged

Remove 'Settings' link from sidebar nav #1901

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dcdba7e
Remove 'Settings' link from sidebar nav
charliepark Jan 22, 2024
0b4000f
Remove 'system' links from path-builder
charliepark Jan 22, 2024
6b0de99
Remove settings route
charliepark Jan 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions app/layouts/SystemLayout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,7 @@ import { useMemo } from 'react'
import { useLocation, useNavigate, useParams } from 'react-router-dom'

import { apiQueryClient } from '@oxide/api'
import {
Cloud16Icon,
Divider,
Metrics16Icon,
Settings16Icon,
Storage16Icon,
} from '@oxide/ui'
import { Cloud16Icon, Divider, Metrics16Icon, Storage16Icon } from '@oxide/ui'

import { trigger404 } from 'app/components/ErrorBoundary'
import { DocsLinkItem, NavLinkItem, Sidebar } from 'app/components/Sidebar'
Expand Down Expand Up @@ -118,9 +112,6 @@ export default function SystemLayout() {
<NavLinkItem to={pb.systemNetworking()} disabled>
<Networking16Icon /> Networking
</NavLinkItem> */}
<NavLinkItem to={pb.systemSettings()} disabled>
<Settings16Icon /> Settings
</NavLinkItem>
</Sidebar.Nav>
</Sidebar>
<ContentPane />
Expand Down
1 change: 0 additions & 1 deletion app/routes.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,6 @@ export const routes = createRoutesFromElements(
<Route path="health" element={null} handle={{ crumb: 'Health' }} />
<Route path="update" element={null} handle={{ crumb: 'Update' }} />
<Route path="networking" element={null} handle={{ crumb: 'Networking' }} />
<Route path="settings" element={null} handle={{ crumb: 'Settings' }} />
</Route>

<Route index element={<Navigate to={pb.projects()} replace />} />
Expand Down
1 change: 0 additions & 1 deletion app/util/path-builder.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,6 @@ test('path builder', () => {
"systemHealth": "/system/health",
"systemIssues": "/system/issues",
"systemNetworking": "/system/networking",
"systemSettings": "/system/settings",
"systemUtilization": "/system/utilization",
"vpc": "/projects/p/vpcs/v",
"vpcEdit": "/projects/p/vpcs/v/edit",
Expand Down
1 change: 0 additions & 1 deletion app/util/path-builder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,6 @@ export const pb = {
systemHealth: () => '/system/health',

systemNetworking: () => '/system/networking',
systemSettings: () => '/system/settings',

inventory: () => '/system/inventory',
rackInventory: () => '/system/inventory/racks',
Expand Down