Skip to content

Tweak CSS to remove awkward line wrapping; widen select box #1917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
david-crespo merged 3 commits into from
Jan 29, 2024
Merged

Tweak CSS to remove awkward line wrapping; widen select box #1917

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c4b13c6
Tweak CSS to remove awkward line wrapping; widen select box
charliepark Jan 28, 2024
32e9372
Use `w-64`
benjaminleonard Jan 29, 2024
6467c7a
Overflow with ellipsis
benjaminleonard Jan 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/pages/SiloUtilizationPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ export function SiloUtilizationPage() {
<div className="mb-3 mt-8 flex justify-between gap-3">
<Listbox
selected={filterId}
className="w-48"
className="w-64"
aria-labelledby="filter-id-label"
name="filter-id"
items={projectItems}
Expand Down
2 changes: 1 addition & 1 deletion app/pages/project/instances/instance/tabs/MetricsTab.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ export function MetricsTab() {
<>
<div className="mb-4 flex justify-between">
<Listbox
className="w-48"
className="w-64"
aria-label="Choose disk"
name="disk-name"
selected={diskName}
Expand Down
2 changes: 1 addition & 1 deletion app/pages/system/UtilizationPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ const MetricsTab = () => {
<div className="mb-3 mt-8 flex justify-between gap-3">
<Listbox
selected={filterId}
className="w-48"
className="w-64"
aria-labelledby="filter-id-label"
name="filter-id"
items={siloItems}
Expand Down
2 changes: 1 addition & 1 deletion libs/ui/lib/listbox/Listbox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ export const Listbox = <Value extends string = string>({
)}
{...props}
>
<div className="w-full px-3 text-left">
<div className="w-full overflow-hidden overflow-ellipsis whitespace-pre px-3 text-left">
{selectedItem ? (
// labelString is one line, which is what we need when label is a ReactNode
selectedItem.labelString || selectedItem.label
Expand Down