Move libs/table and libs/pagination into app/
#1971
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
david-crespo
changed the title
libs/table to app/tablelibs/table and libs/pagination into app/
david-crespo
commented
Feb 23, 2024
david-crespo
force-pushed
the
move-table-into-app
branch
from
cc9f952 to
3d3bce6
Compare
david-crespo
commented
Feb 23, 2024
| '^@oxide/(.*)$', | ||
| '', | ||
| '^~/(.*)$', | ||
| '^app/(.*)$', |
Collaborator
Author
There was a problem hiding this comment.
This is about sorting ~/ into the right spot when prettier sorts and groups imports.
charliepark
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Feb 27, 2024
oxidecomputer/console@80f1167...e991ec5 * [e991ec5c](oxidecomputer/console@e991ec5c) oxidecomputer/console#1982 * [8e247f28](oxidecomputer/console@8e247f28) get rid of @oxide/gen alias * [7d936d7e](oxidecomputer/console@7d936d7e) oxidecomputer/console#1981 * [b9a6051d](oxidecomputer/console@b9a6051d) delete unused app/table/headers * [0b330247](oxidecomputer/console@0b330247) remove barrel files in app/pages * [e53942ce](oxidecomputer/console@e53942ce) remove dot-path-fix vite plugin while we’re not using it * [1af82bff](oxidecomputer/console@1af82bff) use vite-tsconfig-paths insead of my old manual thing * [0f2411e8](oxidecomputer/console@0f2411e8) oxidecomputer/console#1962 * [bd64c620](oxidecomputer/console@bd64c620) oxidecomputer/console#1978 * [4388a92a](oxidecomputer/console@4388a92a) change pt-2 back to py-2 on AccordionItem * [a0921bd6](oxidecomputer/console@a0921bd6) move msw handlers out of mock-api barrel file * [6ab60b9b](oxidecomputer/console@6ab60b9b) update references to libs/ everywhere * [9b4a6e0f](oxidecomputer/console@9b4a6e0f) move classed out of util barrel * [d731de2b](oxidecomputer/console@d731de2b) oxidecomputer/console#1977 * [6c5883d9](oxidecomputer/console@6c5883d9) oxidecomputer/console#1976 * [6de56b15](oxidecomputer/console@6de56b15) oxidecomputer/console#1975 * [bbf019ee](oxidecomputer/console@bbf019ee) oxidecomputer/console#1973 * [b9c1892d](oxidecomputer/console@b9c1892d) oxidecomputer/console#1974 * [e2e56d87](oxidecomputer/console@e2e56d87) Revert `try .git-blame-ignore-revs`. don’t like it * [1745a752](oxidecomputer/console@1745a752) try .git-blame-ignore-revs * [4bfd2275](oxidecomputer/console@4bfd2275) oxidecomputer/console#1971 * [cb109cba](oxidecomputer/console@cb109cba) oxidecomputer/console#1968 * [264e2cd1](oxidecomputer/console@264e2cd1) oxidecomputer/console#1969 * [3ec255f9](oxidecomputer/console@3ec255f9) Revert `Shuffle @oxide/pagination files (oxidecomputer/console#1970)` * [3eebf491](oxidecomputer/console@3eebf491) oxidecomputer/console#1970
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes here:
libs/tabletoapp/tableand update@oxide/tablealias for thatlibs/paginationtoapp/componentsandapp/hooks(there was a component and a hook), get rid of@oxide/paginationalias (it was only used twice)We're reworking aliases as part of #1964 and I'm thinking the
appvs.libsdistinction doesn't really make sense and we should get rid of it. I picked a couple of smaller pieces here to show what that looks like. It's very simple because of the@oxide/tablealias: we don't have to change any imports, all we have to do is change what the alias points to. With pagination there were only two imports so I converted those to the~/paginationstyle already.After moving all the libs into
app, we can scrap the aliases altogether in favor of having~/*simply point toapp/*, and all the imports become~/table/cells/DateCellor whatever.