Access roles refactor suggestions #2089
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
david-crespo
commented
Mar 21, 2024
| const roleBadges = sortBy( | ||
| [siloAccessRow, projectAccessRow].filter(isTruthy), | ||
| (r) => roleOrder[r.roleName] // sorts strongest role first | ||
| ) |
Collaborator
Author
There was a problem hiding this comment.
This filter and sort takes care of what the ternaries were doing.
charliepark
added a commit
that referenced
this pull request
Mar 22, 2024
* Add Type column to access table * Remove old Project and Silo role columns * Remove duplicate columns Co-authored-by: David Crespo <david-crespo@users.noreply.github.com> * Add component for ExpandedCountWithDetails * Access roles refactor suggestions (#2089) * mostly move role badges logic out of cell * ListPlusCell * extract TipIcon and add one to Role column header --------- Co-authored-by: David Crespo <david.crespo@oxidecomputer.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My suggestions for #2062 were too complicated to put into comments. The resulting UI is the same except I called the tooltip "other roles" instead of figuring out which is in there.