ListPlusCell for firewall rule filters
#2163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
david-crespo
force-pushed
the
firewall-rule-list-plus
branch
from
f9495c3 to
dcf0546
Compare
david-crespo
force-pushed
the
firewall-rule-list-plus
branch
from
dcf0546 to
aa94e4a
Compare
Collaborator
Author
|
This looks good and I think it works pretty well, almost certainly better than overflowing. The only problem I have with it is that it makes the table pretty wide when there are two things in the cell. 
One way around that is to only show at most one inline, though that's kind of crappy, especially if there are exactly two. 
I think my ideal setup would be to leave the table as a tall table and encourage these two wrap so we could fit at least 2 or 3 in there before having to overflowing into the popup. |
Collaborator
Author
|
As discussed in chat, in a followup I will experiment with putting the whole list in the popover, not just the "rest". |
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Apr 26, 2024
oxidecomputer/console@d2a9345...43f325d * [43f325d6](oxidecomputer/console@43f325d6) oxidecomputer/console#2200 * [3b574e53](oxidecomputer/console@3b574e53) oxidecomputer/console#2163 * [b8c79ca8](oxidecomputer/console@b8c79ca8) oxidecomputer/console#2198 * [f7fb90aa](oxidecomputer/console@f7fb90aa) oxidecomputer/console#2197 * [2e7e4a0a](oxidecomputer/console@2e7e4a0a) oxidecomputer/console#2190 * [1e576fcb](oxidecomputer/console@1e576fcb) oxidecomputer/console#2192 * [7c56214f](oxidecomputer/console@7c56214f) oxidecomputer/console#2188
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Apr 26, 2024
oxidecomputer/console@d2a9345...e7b243b * [e7b243ba](oxidecomputer/console@e7b243ba) oxidecomputer/console#2203 * [43f325d6](oxidecomputer/console@43f325d6) oxidecomputer/console#2200 * [3b574e53](oxidecomputer/console@3b574e53) oxidecomputer/console#2163 * [b8c79ca8](oxidecomputer/console@b8c79ca8) oxidecomputer/console#2198 * [f7fb90aa](oxidecomputer/console@f7fb90aa) oxidecomputer/console#2197 * [2e7e4a0a](oxidecomputer/console@2e7e4a0a) oxidecomputer/console#2190 * [1e576fcb](oxidecomputer/console@1e576fcb) oxidecomputer/console#2192 * [7c56214f](oxidecomputer/console@7c56214f) oxidecomputer/console#2188
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Apr 26, 2024
oxidecomputer/console@d2a9345...e7b243b * [e7b243ba](oxidecomputer/console@e7b243ba) oxidecomputer/console#2203 * [43f325d6](oxidecomputer/console@43f325d6) oxidecomputer/console#2200 * [3b574e53](oxidecomputer/console@3b574e53) oxidecomputer/console#2163 * [b8c79ca8](oxidecomputer/console@b8c79ca8) oxidecomputer/console#2198 * [f7fb90aa](oxidecomputer/console@f7fb90aa) oxidecomputer/console#2197 * [2e7e4a0a](oxidecomputer/console@2e7e4a0a) oxidecomputer/console#2190 * [1e576fcb](oxidecomputer/console@1e576fcb) oxidecomputer/console#2192 * [7c56214f](oxidecomputer/console@7c56214f) oxidecomputer/console#2188
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a fun idea to close #2118.