Turn on react/button-has-type lint rule and fix all #2261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
charliepark
approved these changes
May 24, 2024
Contributor
|
a fun find |
Contributor
|
Such a useful rule. Wish there was an easy way to share the lint rules we use here to the others without doing it manually. |
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Jun 7, 2024
…nsole) oxidecomputer/console@a228b75...13d46e8 * [13d46e8f](oxidecomputer/console@13d46e8f) oxidecomputer/console#2272 * [13ce748f](oxidecomputer/console@13ce748f) oxidecomputer/console#2269 * [ab2939bf](oxidecomputer/console@ab2939bf) oxidecomputer/console#2262 * [c9f2bba3](oxidecomputer/console@c9f2bba3) oxidecomputer/console#2252 * [9b7ea533](oxidecomputer/console@9b7ea533) oxidecomputer/console#2261 * [bf97ebc2](oxidecomputer/console@bf97ebc2) oxidecomputer/console#2259 * [a18c7a8f](oxidecomputer/console@a18c7a8f) don't need to exclude IE 11 anymore
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Jun 7, 2024
oxidecomputer/console@a228b75...69ba87b * [69ba87b7](oxidecomputer/console@69ba87b7) oxidecomputer/console#2246 * [13d46e8f](oxidecomputer/console@13d46e8f) oxidecomputer/console#2272 * [13ce748f](oxidecomputer/console@13ce748f) oxidecomputer/console#2269 * [ab2939bf](oxidecomputer/console@ab2939bf) oxidecomputer/console#2262 * [c9f2bba3](oxidecomputer/console@c9f2bba3) oxidecomputer/console#2252 * [9b7ea533](oxidecomputer/console@9b7ea533) oxidecomputer/console#2261 * [bf97ebc2](oxidecomputer/console@bf97ebc2) oxidecomputer/console#2259 * [a18c7a8f](oxidecomputer/console@a18c7a8f) don't need to exclude IE 11 anymore
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Jun 7, 2024
oxidecomputer/console@a228b75...7fa8e6d * [7fa8e6d1](oxidecomputer/console@7fa8e6d1) oxidecomputer/console#2274 * [69ba87b7](oxidecomputer/console@69ba87b7) oxidecomputer/console#2246 * [13d46e8f](oxidecomputer/console@13d46e8f) oxidecomputer/console#2272 * [13ce748f](oxidecomputer/console@13ce748f) oxidecomputer/console#2269 * [ab2939bf](oxidecomputer/console@ab2939bf) oxidecomputer/console#2262 * [c9f2bba3](oxidecomputer/console@c9f2bba3) oxidecomputer/console#2252 * [9b7ea533](oxidecomputer/console@9b7ea533) oxidecomputer/console#2261 * [bf97ebc2](oxidecomputer/console@bf97ebc2) oxidecomputer/console#2259 * [a18c7a8f](oxidecomputer/console@a18c7a8f) don't need to exclude IE 11 anymore
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Jun 7, 2024
oxidecomputer/console@a228b75...a9b325e * [a9b325e9](oxidecomputer/console@a9b325e9) forgot to revert tweak for testing * [7fa8e6d1](oxidecomputer/console@7fa8e6d1) oxidecomputer/console#2274 * [69ba87b7](oxidecomputer/console@69ba87b7) oxidecomputer/console#2246 * [13d46e8f](oxidecomputer/console@13d46e8f) oxidecomputer/console#2272 * [13ce748f](oxidecomputer/console@13ce748f) oxidecomputer/console#2269 * [ab2939bf](oxidecomputer/console@ab2939bf) oxidecomputer/console#2262 * [c9f2bba3](oxidecomputer/console@c9f2bba3) oxidecomputer/console#2252 * [9b7ea533](oxidecomputer/console@9b7ea533) oxidecomputer/console#2261 * [bf97ebc2](oxidecomputer/console@bf97ebc2) oxidecomputer/console#2259 * [a18c7a8f](oxidecomputer/console@a18c7a8f) don't need to exclude IE 11 anymore
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Jun 8, 2024
…es) (#5871) oxidecomputer/console@a228b75...a9b325e * [a9b325e9](oxidecomputer/console@a9b325e9) forgot to revert tweak for testing * [7fa8e6d1](oxidecomputer/console@7fa8e6d1) oxidecomputer/console#2274 * [69ba87b7](oxidecomputer/console@69ba87b7) oxidecomputer/console#2246 * [13d46e8f](oxidecomputer/console@13d46e8f) oxidecomputer/console#2272 * [13ce748f](oxidecomputer/console@13ce748f) oxidecomputer/console#2269 * [ab2939bf](oxidecomputer/console@ab2939bf) oxidecomputer/console#2262 * [c9f2bba3](oxidecomputer/console@c9f2bba3) oxidecomputer/console#2252 * [9b7ea533](oxidecomputer/console@9b7ea533) oxidecomputer/console#2261 * [bf97ebc2](oxidecomputer/console@bf97ebc2) oxidecomputer/console#2259 * [a18c7a8f](oxidecomputer/console@a18c7a8f) don't need to exclude IE 11 anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered because of a delightful bug in #2252 (comment). This actually fixes an existing bug on the instance create form where if you press enter to submit the form while in the name field, for example, it will remove an attached disk.
Closes #2260 too.
Bug demo
When the disk disappears, that's because I've pressed enter with a random text input focused.
2024-05-24-button-type-bug.mp4