Skip to content

More firewall rule form help copy #2286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
david-crespo merged 3 commits into from
Jun 26, 2024
Merged

More firewall rule form help copy #2286

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4eb4599
Add helper text to firewall form
charliepark Jun 24, 2024
ccd1a01
Use Message component
charliepark Jun 24, 2024
b3ed3c7
might as well go all out
david-crespo Jun 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 34 additions & 3 deletions app/forms/firewall-rules-create.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,12 @@ export const CommonFields = ({ error, control }: CommonFieldsProps) => {
label="Direction of traffic"
column
control={control}
description={
<>
An inbound rule applies to traffic <em>to</em> the targets, while an outbound
rule applies to traffic <em>from</em> the targets.
</>
}
items={[
{ value: 'inbound', label: 'Inbound' },
{ value: 'outbound', label: 'Outbound' },
Expand All @@ -247,7 +253,15 @@ export const CommonFields = ({ error, control }: CommonFieldsProps) => {
<h3 className="mb-4 text-sans-2xl">Targets</h3>
<Message
variant="info"
content="Targets determine the instances to which this rule applies. You can target instances directly or specify a VPC, VPC subnet, IP, or IP subnet which will apply the rule to all matching instances. Targets are additive: the rule applies to instances matching any target."
content={
<>
Targets determine the instances to which this rule applies. You can target
instances directly by name, or specify a VPC, VPC subnet, IP, or IP subnet,
which will apply the rule to traffic going to all matching instances. Targets
are additive: the rule applies to instances matching{' '}
<span className="underline">any</span> target.
</>
}
/>
{/* TODO: make ListboxField smarter with the values like RadioField is */}
<ListboxField
Expand Down Expand Up @@ -338,7 +352,14 @@ export const CommonFields = ({ error, control }: CommonFieldsProps) => {

<Message
variant="info"
content="Filters reduce the scope of this rule. Without filters, the rule applies to all traffic to the targets (or from the targets, if it's an outbound rule). With multiple filters, it applies to traffic matching all filters."
content={
<>
Filters reduce the scope of this rule. Without filters, the rule applies to all
traffic to the targets (or from the targets, if it&rsquo;s an outbound rule).
With multiple filters, the rule applies to traffic matching{' '}
<span className="underline">all</span> filters.
</>
}
/>

<div className="flex flex-col gap-3">
Expand All @@ -349,7 +370,7 @@ export const CommonFields = ({ error, control }: CommonFieldsProps) => {
Port filters
</label>
<TextInputHint id="portRange-help-text" className="mb-2">
A single port (1234) or a range (1234&ndash;2345)
A single destination port (1234) or a range (1234&ndash;2345)
</TextInputHint>
<TextFieldInner
id="portRange"
Expand Down Expand Up @@ -426,6 +447,16 @@ export const CommonFields = ({ error, control }: CommonFieldsProps) => {

<div className="flex flex-col gap-3">
<h3 className="mt-4 text-sans-lg">Host filters</h3>
<Message
variant="info"
content={
<>
Host filters match the &ldquo;other end&rdquo; of traffic from the
target&rsquo;s perspective: for an inbound rule, they match the source of
traffic. For an outbound rule, they match the destination.
</>
}
/>
<ListboxField
name="type"
label="Host type"
Expand Down