-
Notifications
You must be signed in to change notification settings - Fork 19
Add button to attach an ephemeral IP #2290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| query: { project }, | ||
| body: { pool }, | ||
| }) | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a note, no changes needed: I was wondering if we could get this submit working through the normal onSubmit mechanism on the form. But because of how Modal.Footer works:
Lines 142 to 150 in 34c648b
| <Button | |
| size="sm" | |
| variant={actionType} | |
| onClick={onAction} | |
| disabled={disabled} | |
| loading={actionLoading} | |
| > | |
| {actionText} | |
| </Button> |
we don't have the direct control over the button, which would let us set form={formRef} type="submit" on it, which would let us the put this functionality in the onSubmit on the form.
david-crespo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's party
oxidecomputer/console@34c648b...8febc79 * [8febc798](oxidecomputer/console@8febc798) oxidecomputer/console#2297 * [0d28797c](oxidecomputer/console@0d28797c) fix e2e test for change to mock API error messages * [f5e52090](oxidecomputer/console@f5e52090) oxidecomputer/console#2299 * [db99a4db](oxidecomputer/console@db99a4db) oxidecomputer/console#2293 * [1f9ba6f8](oxidecomputer/console@1f9ba6f8) oxidecomputer/console#2292 * [84727c64](oxidecomputer/console@84727c64) oxidecomputer/console#2291 * [e782bf20](oxidecomputer/console@e782bf20) oxidecomputer/console#2290
oxidecomputer/console@34c648b...8febc79 * [8febc798](oxidecomputer/console@8febc798) oxidecomputer/console#2297 * [0d28797c](oxidecomputer/console@0d28797c) fix e2e test for change to mock API error messages * [f5e52090](oxidecomputer/console@f5e52090) oxidecomputer/console#2299 * [db99a4db](oxidecomputer/console@db99a4db) oxidecomputer/console#2293 * [1f9ba6f8](oxidecomputer/console@1f9ba6f8) oxidecomputer/console#2292 * [84727c64](oxidecomputer/console@84727c64) oxidecomputer/console#2291 * [e782bf20](oxidecomputer/console@e782bf20) oxidecomputer/console#2290
Fixes #2288 — enables a means of attaching an ephemeral IP to the instance when the instance …



A) does not have an ephemeral IP,
and
B) has a network interface
Normally, we'd set up a button to be visible-but-disabled when it can't be interacted with. Because the normal state for instances is that they wouldn't need to attach an ephemeral IP (there's a max count of 1 for ephemeral IPs), and it would be a big disabled button cluttering up the UI, we decided to hide the button when they can't attach an ephemeral IP.
