Skip to content

Conversation

@charliepark
Copy link
Contributor

@charliepark charliepark commented Jun 26, 2024

Fixes #2288 — enables a means of attaching an ephemeral IP to the instance when the instance …
A) does not have an ephemeral IP,
and
B) has a network interface
Screenshot 2024-06-27 at 12 21 38 PM
Screenshot 2024-06-27 at 12 21 46 PM
Screenshot 2024-06-27 at 12 21 54 PM

Normally, we'd set up a button to be visible-but-disabled when it can't be interacted with. Because the normal state for instances is that they wouldn't need to attach an ephemeral IP (there's a max count of 1 for ephemeral IPs), and it would be a big disabled button cluttering up the UI, we decided to hide the button when they can't attach an ephemeral IP.
Screenshot 2024-06-27 at 12 27 48 PM

@vercel
Copy link

vercel bot commented Jun 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
console ✅ Ready (Inspect) Visit Preview Jun 27, 2024 6:55pm

@charliepark charliepark marked this pull request as draft June 26, 2024 22:54
@charliepark charliepark marked this pull request as ready for review June 27, 2024 16:28
query: { project },
body: { pool },
})
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note, no changes needed: I was wondering if we could get this submit working through the normal onSubmit mechanism on the form. But because of how Modal.Footer works:

<Button
size="sm"
variant={actionType}
onClick={onAction}
disabled={disabled}
loading={actionLoading}
>
{actionText}
</Button>

we don't have the direct control over the button, which would let us set form={formRef} type="submit" on it, which would let us the put this functionality in the onSubmit on the form.

Copy link
Collaborator

@david-crespo david-crespo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's party

@david-crespo david-crespo enabled auto-merge (squash) June 27, 2024 18:56
@david-crespo david-crespo merged commit e782bf2 into main Jun 27, 2024
@david-crespo david-crespo deleted the add-attach-ephemeral-ip branch June 27, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Instance networking: attach ephemeral IP button

3 participants