Improve combobox implementations in preparation for v9 #2303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliepark
changed the title
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
david-crespo
reviewed
Jul 2, 2024
david-crespo
reviewed
Jul 2, 2024
| disabled={!vpcExists} | ||
| control={control} | ||
| placeholder="Select a subnet" | ||
| noItemsPlaceholder="Select a VPC to see subnets" |
Collaborator
There was a problem hiding this comment.
This should be conditional on whether a VPC has been selected, if possible. If you pick a VPC that genuinely has no subnets, it would be confusing to see this message.
Contributor
Author
There was a problem hiding this comment.
Solid. Have updated it.
david-crespo
reviewed
Jul 2, 2024
david-crespo
reviewed
Jul 2, 2024
david-crespo
approved these changes
Jul 2, 2024
Collaborator
david-crespo
left a comment
david-crespo
left a comment
There was a problem hiding this comment.
Looks good. The comments are just suggestions.
Co-authored-by: David Crespo <david-crespo@users.noreply.github.com>
david-crespo
reviewed
Jul 2, 2024
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Jul 3, 2024
oxidecomputer/console@8febc79...00b7602 * [00b76026](oxidecomputer/console@00b76026) oxidecomputer/console#2312 * [3a2e3e1f](oxidecomputer/console@3a2e3e1f) oxidecomputer/console#2311 * [f30a3ba6](oxidecomputer/console@f30a3ba6) oxidecomputer/console#2305 * [a1a23da5](oxidecomputer/console@a1a23da5) oxidecomputer/console#2304 * [b590b9b6](oxidecomputer/console@b590b9b6) oxidecomputer/console#2303 * [1a22b73d](oxidecomputer/console@1a22b73d) oxidecomputer/console#2301 * [dd7f6f9c](oxidecomputer/console@dd7f6f9c) oxidecomputer/console#2300
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Jul 3, 2024
oxidecomputer/console@8febc79...00b7602 * [00b76026](oxidecomputer/console@00b76026) oxidecomputer/console#2312 * [3a2e3e1f](oxidecomputer/console@3a2e3e1f) oxidecomputer/console#2311 * [f30a3ba6](oxidecomputer/console@f30a3ba6) oxidecomputer/console#2305 * [a1a23da5](oxidecomputer/console@a1a23da5) oxidecomputer/console#2304 * [b590b9b6](oxidecomputer/console@b590b9b6) oxidecomputer/console#2303 * [1a22b73d](oxidecomputer/console@1a22b73d) oxidecomputer/console#2301 * [dd7f6f9c](oxidecomputer/console@dd7f6f9c) oxidecomputer/console#2300
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a few general improvements to the combobox component and a few forms that use either comboboxes or listboxes.
Select a disk,Select a pool, etc., rather thanSelect pool, etc.