Skip to content

Remove cmd+k quick actions from instance detail page #2305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
david-crespo merged 1 commit into from
Jul 2, 2024
Merged

Remove cmd+k quick actions from instance detail page #2305

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 1 addition & 13 deletions app/pages/project/instances/instance/InstancePage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ import { MoreActionsMenu } from '~/components/MoreActionsMenu'
import { RefreshButton } from '~/components/RefreshButton'
import { RouteTabs, Tab } from '~/components/RouteTabs'
import { InstanceStatusBadge } from '~/components/StatusBadge'
import { getInstanceSelector, useInstanceSelector, useQuickActions } from '~/hooks'
import { getInstanceSelector, useInstanceSelector } from '~/hooks'
import { EmptyCell } from '~/table/cells/EmptyCell'
import { DateTime } from '~/ui/lib/DateTime'
import { PageHeader, PageTitle } from '~/ui/lib/PageHeader'
Expand Down Expand Up @@ -128,18 +128,6 @@ export function InstancePage() {
],
[instance, makeActions]
)
const quickActions = useMemo(
() =>
actions
// in the quick menu we do not show disabled actions
.filter((a) => !a.disabled)
// append "instance" to labels
// TODO: if these were in an "Instance actions" subsection they might not
// need the suffix for clarity
.map((a) => ({ onSelect: a.onActivate, value: a.label })),
[actions]
)
useQuickActions(quickActions)

const memory = filesize(instance.memory, { output: 'object', base: 2 })

Expand Down