Skip to content

Update image 'edit' form title, as form isn't actually editable #2312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
charliepark merged 1 commit into from
Jul 3, 2024
Merged

Update image 'edit' form title, as form isn't actually editable #2312

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions app/forms/image-edit.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ import { PropertiesTable } from '~/ui/lib/PropertiesTable'
import { ResourceLabel } from '~/ui/lib/SideModal'
import { Truncate } from '~/ui/lib/Truncate'
import { pb } from '~/util/path-builder'
import { capitalize } from '~/util/str'
import { bytesToGiB } from '~/util/units'

EditProjectImageSideModalForm.loader = async ({ params }: LoaderFunctionArgs) => {
Expand Down Expand Up @@ -69,12 +70,14 @@ export function EditImageSideModalForm({
}) {
const navigate = useNavigate()
const form = useForm({ defaultValues: image })
const resourceName = type === 'Project' ? 'project image' : 'silo image'

return (
<SideModalForm
title={capitalize(resourceName)}
form={form}
formType="edit"
resourceName={type === 'Project' ? 'project image' : 'silo image'}
resourceName={resourceName}
onDismiss={() => navigate(dismissLink)}
subtitle={
<ResourceLabel>
Expand All @@ -100,7 +103,6 @@ export function EditImageSideModalForm({
<DateTime date={image.timeModified} />
</PropertiesTable.Row>
</PropertiesTable>

<NameField name="name" control={form.control} disabled />
<DescriptionField name="description" control={form.control} required disabled />
<TextField name="os" label="OS" control={form.control} required disabled />
Expand Down