Skip to content

Truncate truncated descriptions even more #2404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
david-crespo merged 1 commit into from
Sep 11, 2024
Merged

Truncate truncated descriptions even more #2404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions app/ui/lib/Truncate.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,12 @@ export const Truncate = ({

// Only use the tooltip if the text is longer than maxLength
return (
<div className="flex items-center space-x-2">
// overflow-hidden required to make inner truncate work
<div className="flex items-center space-x-2 overflow-hidden">
<Tooltip content={text} delay={tooltipDelay}>
<div aria-label={text}>{truncate(text, maxLength, position)}</div>
<div aria-label={text} className="truncate">
{truncate(text, maxLength, position)}
</div>
</Tooltip>
{hasCopyButton && <CopyToClipboard text={text} />}
</div>
Expand Down
2 changes: 1 addition & 1 deletion mock-api/vpc.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ export const vpcs: Json<Vpc[]> = [vpc, vpc2]
export const defaultRouter: Json<VpcRouter> = {
id: 'fc59fb4d-baad-44a8-b152-9a3c27ae8aa1',
name: 'mock-system-router',
description: 'a fake router',
description: 'Routes are automatically added to this router as VPC subnets are created',
Copy link
Collaborator Author

@david-crespo david-crespo Sep 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Match the real default description given to system routers

time_created: new Date(2024, 0, 1).toISOString(),
time_modified: new Date(2024, 0, 2).toISOString(),
vpc_id: vpc.id,
Expand Down